From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f177.google.com (mail-ie0-f177.google.com [209.85.223.177]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id A1FAB1A08F5 for ; Tue, 18 Nov 2014 18:10:41 +1100 (AEDT) Received: by mail-ie0-f177.google.com with SMTP id tr6so4502993ieb.22 for ; Mon, 17 Nov 2014 23:10:39 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1416207214.2826.3.camel@concordia> References: <1415956325-10124-1-git-send-email-vvijayan@mvista.com> <1416207214.2826.3.camel@concordia> From: Vineeth Vijayan Date: Tue, 18 Nov 2014 12:40:19 +0530 Message-ID: Subject: Re: [PATCH] [powerpc] Fix Text randomization To: Michael Ellerman Content-Type: multipart/alternative; boundary=047d7bdc9daee4d8b405081ccadc Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Anton Blanchard List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --047d7bdc9daee4d8b405081ccadc Content-Type: text/plain; charset=UTF-8 On Mon, Nov 17, 2014 at 12:23 PM, Michael Ellerman wrote: > On Fri, 2014-11-14 at 14:42 +0530, Vineeth Vijayan wrote: > > Now there is no way to disable TEXT randomization on a PPC32/PPC64 > > machine. Text randomization happens even in the case of "echo 0 > > > /proc/sys/kernel/randomize_va_space" > > > > This happens due to the incorrect definition of ELF_ET_DYN_BASE > > at arch/powerpc/include/asm/elf.h > > > > The function randomize_et_dyn is redundant and is removed. > > The patch looks OK, but for the change log I was thinking something more > like > this: > > > powerpc: Use generic PIE randomization > > Do you want me to send a new patch with updated change log as mentioned ? --047d7bdc9daee4d8b405081ccadc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Mon, Nov 17, 2014 at 12:23 PM, Michael Ellerman &l= t;mpe@ellerman.id.a= u> wrote:
= On Fri, 2014-11-14 at 14:42 +0530, Vineeth Vijayan wrote:
> Now there is no way to disable TEXT randomization on a PPC32/PPC64
> machine. Text randomization happens even in the case of "echo 0 &= gt;
> /proc/sys/kernel/randomize_va_space"
>
> This happens due to the incorrect definition of ELF_ET_DYN_BASE
> at arch/powerpc/include/asm/elf.h
>
> The function randomize_et_dyn is redundant and is removed.

The patch looks OK, but for the change log I was thinking something = more like
this:


powerpc: Use generic PIE randomization

Do you want me to send a new patch with updated chang= e log as mentioned ?
--047d7bdc9daee4d8b405081ccadc--