From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F28E9C25B4E for ; Tue, 24 Jan 2023 04:50:44 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4P1F0M2Glgz3cf8 for ; Tue, 24 Jan 2023 15:50:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=TwUkV4fD; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2a00:1450:4864:20::431; helo=mail-wr1-x431.google.com; envelope-from=irogers@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=TwUkV4fD; dkim-atps=neutral Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4P1Dz728Zvz3cC1 for ; Tue, 24 Jan 2023 15:49:39 +1100 (AEDT) Received: by mail-wr1-x431.google.com with SMTP id d2so12688723wrp.8 for ; Mon, 23 Jan 2023 20:49:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DK6xaXE5oASyoDQtrld9FdvxBPYhIcRWULm9bEl36oc=; b=TwUkV4fDTn80NzdblDeqyIin7jJkGsyJZv9xSAjsM0BiUikLoxf1xGH8bY9R2rjHPk a4+Z3X4imr2ZpgYOMcxQWc0tsIhOYrT/y9aPK2Kzln2qjuB7zdGgCJMZQVTAbp00F+5V cAUDa1iXdcq13wWfbGtPGluLFs0fxCsTkvDpqJsYQAOD+zLvQZifMxj9JAKYIDbYetGC v4mKhvfMnTL3WsdDqv0tvPZyF9ePAUTW567psXo1g2Sk/ZyGTbaxsNA+GQoTzB+fmZgj vZPjxPitfgtSYrthW9g4vF67tPEG+JQdG6XsutwsBFSgKY9U+L5ACvzJLIZ9GYkh4Rss LU1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DK6xaXE5oASyoDQtrld9FdvxBPYhIcRWULm9bEl36oc=; b=FdbUbzd3xnQifLa/lZfOkKQ3QRdaFvXqg/TDlWL2hLWUPAm43k2VVdrNfn/TmTVdT8 g0mfqzlDtRxXFp0Uhcbls7P7zRvtHOf70sa4bmKicv0hdDYMEcTQTSjSUuvP52sbllRl TIa9iqiahcCQ2fjmG7kAaONCfBlZWdeEcRQ1fyOC2XJhGT93N2jqFobZ+m5zGbCkv3e+ 1kIZDW0mwxoQEaiNKyHBrjwMyvrASoyCT1+IPNFv0Y0btqHg2Qn+wC6p77xi/IFqAvgM 80cJMwOReAFg/HJPlwl8qUU6fF9gTWGrbV/3kUY8nPXnR+bZhpvbAGd0xOOGFOEmOGG7 fA7g== X-Gm-Message-State: AFqh2kpOS1pLzr37q+rAN1LiVyYXWT/KxqPJaPT4dINKCj6CLnH7YELY yHxy6cOZEBQ+u3ag+5R8fjJqSopwzV0eDeHlfkTSAQ== X-Google-Smtp-Source: AMrXdXunWqevhFj8/tiwX31/k0NTL79Bsn3aXdolVljl3gNlXwKl2/xgYzhiUMRWVNro/K9uQqDGitK/0NB1Ie/+DpM= X-Received: by 2002:a05:6000:1d9b:b0:2bc:aa47:bf7a with SMTP id bk27-20020a0560001d9b00b002bcaa47bf7amr674533wrb.343.1674535775796; Mon, 23 Jan 2023 20:49:35 -0800 (PST) MIME-Version: 1.0 References: <20221221223420.2157113-1-irogers@google.com> <20221221223420.2157113-9-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Mon, 23 Jan 2023 20:49:23 -0800 Message-ID: Subject: Re: [PATCH v2 8/9] perf jevents: Generate metrics and events as separate tables To: John Garry Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kang Minchul , Sandipan Das , Peter Zijlstra , Perry Taylor , Stephane Eranian , linux-kernel@vger.kernel.org, James Clark , Kim Phillips , Will Deacon , Kan Liang , Rob Herring , Alexander Shishkin , Ingo Molnar , Xing Zhengjun , Mike Leach , Kajol Jain , Arnaldo Carvalho de Melo , Namhyung Kim , Caleb Biggers , linux-arm-kernel@lists.infradead.org, Ravi Bangoria , Florian Fischer , Adrian Hunter , linux-perf-users@vger.kernel.org, Jiri Olsa , Leo Yan , linuxppc-dev@lists.ozlabs.org, Jing Zhang Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jan 23, 2023 at 7:18 AM John Garry wrote: > > On 21/12/2022 22:34, Ian Rogers wrote: > > Turn a perf json event into an event, metric or both. This reduces the > > number of events needed to scan to find an event or metric. As events > > no longer need the relatively seldom used metric fields, 4 bytes is > > saved per event. This reduces the big C string's size by 335kb (14.8%) > > on x86. > > > > Signed-off-by: Ian Rogers > > It would have been good to show an example of how the output changes. I > could not apply the series (see cover), and knowing what to expect makes > reviewing the code easier... > > Thanks, > John Thanks, will add in v3. Ian