From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C539C636D3 for ; Fri, 3 Feb 2023 01:42:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4P7JLf6Cwlz3f6W for ; Fri, 3 Feb 2023 12:42:34 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=JGGtJ43m; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2a00:1450:4864:20::42e; helo=mail-wr1-x42e.google.com; envelope-from=irogers@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=JGGtJ43m; dkim-atps=neutral Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4P7JKd6xZ0z3bhW for ; Fri, 3 Feb 2023 12:41:41 +1100 (AEDT) Received: by mail-wr1-x42e.google.com with SMTP id m14so3350953wrg.13 for ; Thu, 02 Feb 2023 17:41:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rothOJAx61IhY6WBzLgJ0pLvV1L69tGtBH8EM756NO8=; b=JGGtJ43mQQSjD5iDplV0TKr5vkx/VXre07uHn16ZwJoqK0iPdnRFzazXeDBOc7drVf iA0hyjJJhKMHtfH3J1Dlkupz5f3mvNhyF4tWWBBqrdkFifGWfW9vpiP1LYtm1tANuk5x CDkTWs5aoqcOApygErzXmNuu4KVA8GufFtqBRQC7GQDvOiJnodRDgjgOpWpiY69JlNvB hDUGM9TfhF2P6C/nUPpC3ICMfxp6eOUe40TgBJKFqZfK5ZUtLJYNCc+2Ua8JNjpE5nZD DOTe6XGkYm+xIa2VVRfMFDypR9RQhzOvDmr5R+sFK2m6siyVBbM+pn0sDza4ltIdKkYe /KRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rothOJAx61IhY6WBzLgJ0pLvV1L69tGtBH8EM756NO8=; b=uV/shu6XI7hh/JbtawpEcMkR7hJHcFRekqnm0CsxIIBVoMTtwRAoplofDZb1Tzs+5U gPToBNkp6gb+ck6V5lhGJtkn2lk8IccKGCQoro7cO5NRzsBgPHJolzri2V1YiWvhAs0C HYhIeQdw0L5lmknUgtPS+JVWLdvbLPNEGCbJqv9k115KUC02TpLieFOlr4fU/qhHTG58 p4Zn84LS4JeSXfRLUUDY1ru0RxUUbNn15cZZq4ljOcchfRnwce6QO9RsmTDWt/DuMtmW 0qW9fDychkwUxCav3HBxFY7rZCeW9hWy2v/xfpziEUzWo/wfuZtDXgLpgArlOC80cuXQ I3mQ== X-Gm-Message-State: AO0yUKVs7cUyzdtktPI+1b5gpp3apR0vzZBWssB0PtU5fDaF9WO97Ist Gw+uCcvtaq7+Wds8FOGcuhw3aZNZyo4Q4HlVRgpYzg== X-Google-Smtp-Source: AK7set9KcFxcgBgOvFlB4117j0vmSRXNYNO65A30gArABQfkcUEfrN38aSMQU2A/k5B0ndvaCL9HCt0EhVPjdSUZ6Oc= X-Received: by 2002:adf:e351:0:b0:2bf:eba5:b652 with SMTP id n17-20020adfe351000000b002bfeba5b652mr196573wrj.19.1675388494864; Thu, 02 Feb 2023 17:41:34 -0800 (PST) MIME-Version: 1.0 References: <20230203014014.75720-1-irogers@google.com> In-Reply-To: <20230203014014.75720-1-irogers@google.com> From: Ian Rogers Date: Thu, 2 Feb 2023 17:41:22 -0800 Message-ID: Subject: Re: [PATCH v1] perf pmu: Fix aarch64 build To: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Kim Phillips , Florian Fischer , Ravi Bangoria , Xing Zhengjun , Rob Herring , Kang Minchul , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Sandipan Das , Jing Zhang , linuxppc-dev@lists.ozlabs.org, Kajol Jain Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Perry Taylor , Caleb Biggers , Stephane Eranian Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Feb 2, 2023 at 5:40 PM Ian Rogers wrote: > > ARM64 overrides a weak function but a previous change had broken the > build. > > Fixes: 8cefeb8bd336 ("perf pmu-events: Introduce pmu_metrics_table") As 8cefeb8bd336 ("perf pmu-events: Introduce pmu_metrics_table") is only on tmp.perf/core then it may be best to just squash this fix into that. Thanks, Ian > Signed-off-by: Ian Rogers > --- > tools/perf/arch/arm64/util/pmu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/arch/arm64/util/pmu.c b/tools/perf/arch/arm64/util/pmu.c > index 2779840d8896..fa143acb4c8d 100644 > --- a/tools/perf/arch/arm64/util/pmu.c > +++ b/tools/perf/arch/arm64/util/pmu.c > @@ -22,6 +22,8 @@ static struct perf_pmu *pmu__find_core_pmu(void) > return NULL; > > return pmu; > + } > + return NULL; > } > > const struct pmu_metrics_table *pmu_metrics_table__find(void) > -- > 2.39.1.519.gcb327c4b5f-goog >