From: Kumar Gala <galak@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] Better timer and RTC handling for 8641HPCN.
Date: Wed, 7 Mar 2007 13:48:58 -0600 [thread overview]
Message-ID: <CBC6BDF5-EB84-463C-A53C-1204CC396D5F@kernel.crashing.org> (raw)
In-Reply-To: <20070307193438.GA30721@ld0162-tx32.am.freescale.net>
On Mar 7, 2007, at 1:34 PM, Scott Wood wrote:
> On Wed, Mar 07, 2007 at 01:19:29PM -0600, Kumar Gala wrote:
>> On Mar 7, 2007, at 12:49 PM, Jon Loeliger wrote:
>>> From: Zhang Wei <wei.zhang@freescale.com>
>>>
>>> Give more IRQ numbers for MPIC IPIs and TIMERs use.
>>> Added generic RTC support for MPC8641HPCN.
>>>
>>> Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
>>> Signed-off-by: Jon Loeliger <jdl@freescale.com>
>>
>> Nack.
>>
>> You can't call the generic set_rtc_time from the
>> ppc_md.set_rtc_time. Take a look at:
>>
>> http://ozlabs.org/pipermail/linuxppc-dev/2007-January/030440.html
>
> set_rtc_time != rtc_set_time. The latter is the one that goes through
> the drivers/rtc stuff and needs a workqueue; the former (which this
> patch
> uses) is in asm-generic/rtc.h, and appears to be interrupt-safe.
I ah, didn't notice.. Well I don't think set_rtc_time/get_rtc_time do
anything useful for most ppc's, since it seems they use CMOS_READ/
CMOS_WRITE which is only defined in asm/mc146818rtc.h
- k
next prev parent reply other threads:[~2007-03-07 19:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 18:49 [PATCH] Better timer and RTC handling for 8641HPCN Jon Loeliger
2007-03-07 19:19 ` Kumar Gala
2007-03-07 19:34 ` Scott Wood
2007-03-07 19:48 ` Kumar Gala [this message]
2007-03-08 1:56 ` Zhang Wei-r63237
2007-03-08 2:47 ` Kumar Gala
2007-03-08 5:38 ` Zhang Wei-r63237
2007-03-08 5:57 ` Kumar Gala
2007-03-08 19:10 ` Jon Loeliger
2007-03-08 19:19 ` Haiying Wang
2007-03-08 19:24 ` Kumar Gala
2007-03-09 1:51 ` Zhang Wei-r63237
2007-03-09 3:48 ` Kumar Gala
2007-03-09 4:23 ` Zhang Wei-r63237
2007-03-09 4:52 ` Kumar Gala
2007-03-09 5:24 ` Zhang Wei-r63237
2007-03-09 16:12 ` IRQ numbering (was: Better timer and RTC handling for 8641HPCN.) Kumar Gala
2007-03-12 2:37 ` Zhang Wei-r63237
2007-03-12 3:13 ` Kumar Gala
2007-03-12 3:37 ` Paul Mackerras
2007-03-08 20:34 ` [PATCH] Better timer and RTC handling for 8641HPCN Kim Phillips
2007-03-08 2:09 ` Zhang Wei-r63237
2007-03-08 3:04 ` Kumar Gala
2007-03-08 8:17 ` Zhang Wei-r63237
2007-03-08 8:28 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBC6BDF5-EB84-463C-A53C-1204CC396D5F@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).