LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: Zhao Qiang <B45475@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org,
	Shengzhou Liu <Shengzhou.Liu@freescale.com>
Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree
Date: Wed, 11 Sep 2013 10:12:59 -0500	[thread overview]
Message-ID: <CE821871-A927-4A65-AA69-05F63AF2C6A1@kernel.crashing.org> (raw)
In-Reply-To: <1378871354-22763-1-git-send-email-B45475@freescale.com>


On Sep 10, 2013, at 10:49 PM, Zhao Qiang wrote:

> Since P1010RDB-PA and P1010RDB-PB boards use different external PHY
> interrupt signals.
> And actually the PHY interrupt is not used effectively with
> corresponding interrupt handler.
> So we can remove the interrupts node without side-effect to comply
> with both P1010RDB-PA and P1010RDB-PB.
>=20
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> ---
> arch/powerpc/boot/dts/p1010rdb.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>=20

NAK.  The device tree should represent the HW not what drivers decide to =
do with it.

If different board revs have different interrupt signals than create =
dts's to handle the 2 board revs.

- k

  reply	other threads:[~2013-09-11 15:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11  3:49 [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree Zhao Qiang
2013-09-11 15:12 ` Kumar Gala [this message]
2013-09-12  6:54   ` Liu Shengzhou-B36685
2013-09-12 16:41     ` Kumar Gala
2013-09-13  2:58       ` Zhao Qiang-B45475
2013-09-13  3:17       ` Zhao Qiang-B45475
2013-09-16 22:39         ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CE821871-A927-4A65-AA69-05F63AF2C6A1@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=B45475@freescale.com \
    --cc=Shengzhou.Liu@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox