From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Rohan McLure" <rmclure@linux.ibm.com>, <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 16/23] powerpc: Include all arch-specific syscall prototypes
Date: Tue, 20 Sep 2022 11:27:43 +1000 [thread overview]
Message-ID: <CN0U6W1ZA0GA.1J34ZJPEE7J1D@bobo> (raw)
In-Reply-To: <20220916053300.786330-17-rmclure@linux.ibm.com>
On Fri Sep 16, 2022 at 3:32 PM AEST, Rohan McLure wrote:
> Forward declare all syscall handler prototypes where a generic prototype
> is not provided in either linux/syscalls.h or linux/compat.h in
> asm/syscalls.h. This is required for compile-time type-checking for
> syscall handlers, which is implemented later in this series.
>
> 32-bit compatibility syscall handlers are expressed in terms of types in
> ppc32.h. Expose this header globally.
>
> Signed-off-by: Rohan McLure <rmclure@linux.ibm.com>
I didn't go through all the code moving carefully but I guess that
would blow up with the compile time checking so it must be right :)
Acked-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> V1 -> V2: Explicitly include prototypes.
> V2 -> V3: Remove extraneous #include <asm/compat.h> and ppc_fallocate
> prototype. Rename header.
> V4 -> V5: Clean. Elaborate comment on long long munging. Remove
> prototype hiding conditional on SYSCALL_WRAPPER.
> ---
> arch/powerpc/include/asm/syscalls.h | 97 ++++++++++++++----
> .../ppc32.h => include/asm/syscalls_32.h} | 0
> arch/powerpc/kernel/signal_32.c | 2 +-
> arch/powerpc/perf/callchain_32.c | 2 +-
> 4 files changed, 77 insertions(+), 24 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/syscalls.h b/arch/powerpc/include/asm/syscalls.h
> index 525d2aa0c8ca..5d106acf7906 100644
> --- a/arch/powerpc/include/asm/syscalls.h
> +++ b/arch/powerpc/include/asm/syscalls.h
> @@ -8,6 +8,14 @@
> #include <linux/types.h>
> #include <linux/compat.h>
>
> +#ifdef CONFIG_PPC64
> +#include <asm/syscalls_32.h>
> +#endif
> +#include <asm/unistd.h>
> +#include <asm/ucontext.h>
> +
> +struct rtas_args;
> +
> /*
> * long long munging:
> * The 32 bit ABI passes long longs in an odd even register pair.
> @@ -20,44 +28,89 @@
> #define merge_64(high, low) ((u64)high << 32) | low
> #endif
>
> -struct rtas_args;
> +long sys_ni_syscall(void);
> +
> +/*
> + * PowerPC architecture-specific syscalls
> + */
> +
> +long sys_rtas(struct rtas_args __user *uargs);
> +
> +#ifdef CONFIG_PPC64
> +long sys_ppc64_personality(unsigned long personality);
> +#ifdef CONFIG_COMPAT
> +long compat_sys_ppc64_personality(unsigned long personality);
> +#endif /* CONFIG_COMPAT */
> +#endif /* CONFIG_PPC64 */
>
> +long sys_swapcontext(struct ucontext __user *old_ctx,
> + struct ucontext __user *new_ctx, long ctx_size);
> long sys_mmap(unsigned long addr, size_t len,
> unsigned long prot, unsigned long flags,
> unsigned long fd, off_t offset);
> long sys_mmap2(unsigned long addr, size_t len,
> unsigned long prot, unsigned long flags,
> unsigned long fd, unsigned long pgoff);
> -long sys_ppc64_personality(unsigned long personality);
> -long sys_rtas(struct rtas_args __user *uargs);
> -long sys_ppc_fadvise64_64(int fd, int advice, u32 offset_high, u32 offset_low,
> - u32 len_high, u32 len_low);
> +long sys_switch_endian(void);
>
> -#ifdef CONFIG_COMPAT
> -unsigned long compat_sys_mmap2(unsigned long addr, size_t len,
> - unsigned long prot, unsigned long flags,
> - unsigned long fd, unsigned long pgoff);
> -
> -compat_ssize_t compat_sys_pread64(unsigned int fd, char __user *ubuf, compat_size_t count,
> - u32 reg6, u32 pos1, u32 pos2);
> +#ifdef CONFIG_PPC32
> +long sys_sigreturn(void);
> +long sys_debug_setcontext(struct ucontext __user *ctx, int ndbg,
> + struct sig_dbg_op __user *dbg);
> +#endif
>
> -compat_ssize_t compat_sys_pwrite64(unsigned int fd, const char __user *ubuf, compat_size_t count,
> - u32 reg6, u32 pos1, u32 pos2);
> +long sys_rt_sigreturn(void);
>
> -compat_ssize_t compat_sys_readahead(int fd, u32 r4, u32 offset1, u32 offset2, u32 count);
> +long sys_subpage_prot(unsigned long addr,
> + unsigned long len, u32 __user *map);
>
> -int compat_sys_truncate64(const char __user *path, u32 reg4,
> - unsigned long len1, unsigned long len2);
> +#ifdef CONFIG_COMPAT
> +long compat_sys_swapcontext(struct ucontext32 __user *old_ctx,
> + struct ucontext32 __user *new_ctx,
> + int ctx_size);
> +long compat_sys_old_getrlimit(unsigned int resource,
> + struct compat_rlimit __user *rlim);
> +long compat_sys_sigreturn(void);
> +long compat_sys_rt_sigreturn(void);
> +#endif /* CONFIG_COMPAT */
>
> -int compat_sys_ftruncate64(unsigned int fd, u32 reg4, unsigned long len1,
> - unsigned long len2);
> +/*
> + * Architecture specific signatures required by long long munging:
> + * The 32 bit ABI passes long longs in an odd even register pair.
> + * The following signatures provide a machine long parameter for
> + * each register that will be supplied. The implementation is
> + * responsible for combining parameter pairs.
> + */
>
> +#ifdef CONFIG_COMPAT
> +long compat_sys_mmap2(unsigned long addr, size_t len,
> + unsigned long prot, unsigned long flags,
> + unsigned long fd, unsigned long pgoff);
> +long compat_sys_ppc_pread64(unsigned int fd,
> + char __user *ubuf, compat_size_t count,
> + u32 reg6, u32 pos1, u32 pos2);
> +long compat_sys_ppc_pwrite64(unsigned int fd,
> + const char __user *ubuf, compat_size_t count,
> + u32 reg6, u32 pos1, u32 pos2);
> +long compat_sys_ppc_readahead(int fd, u32 r4,
> + u32 offset1, u32 offset2, u32 count);
> +long compat_sys_ppc_truncate64(const char __user *path, u32 reg4,
> + unsigned long len1, unsigned long len2);
> +long compat_sys_ppc_ftruncate64(unsigned int fd, u32 reg4,
> + unsigned long len1, unsigned long len2);
> long compat_sys_ppc32_fadvise64(int fd, u32 unused, u32 offset1, u32 offset2,
> size_t len, int advice);
> +long compat_sys_ppc_sync_file_range2(int fd, unsigned int flags,
> + unsigned int offset1,
> + unsigned int offset2,
> + unsigned int nbytes1,
> + unsigned int nbytes2);
> +#endif /* CONFIG_COMPAT */
>
> -long compat_sys_sync_file_range2(int fd, unsigned int flags,
> - unsigned int offset1, unsigned int offset2,
> - unsigned int nbytes1, unsigned int nbytes2);
> +#if defined(CONFIG_PPC32) || defined(CONFIG_COMPAT)
> +long sys_ppc_fadvise64_64(int fd, int advice,
> + u32 offset_high, u32 offset_low,
> + u32 len_high, u32 len_low);
> #endif
>
> #endif /* __KERNEL__ */
> diff --git a/arch/powerpc/kernel/ppc32.h b/arch/powerpc/include/asm/syscalls_32.h
> similarity index 100%
> rename from arch/powerpc/kernel/ppc32.h
> rename to arch/powerpc/include/asm/syscalls_32.h
> diff --git a/arch/powerpc/kernel/signal_32.c b/arch/powerpc/kernel/signal_32.c
> index 157a7403e3eb..c114c7f25645 100644
> --- a/arch/powerpc/kernel/signal_32.c
> +++ b/arch/powerpc/kernel/signal_32.c
> @@ -43,7 +43,7 @@
> #include <asm/tm.h>
> #include <asm/asm-prototypes.h>
> #ifdef CONFIG_PPC64
> -#include "ppc32.h"
> +#include <asm/syscalls_32.h>
> #include <asm/unistd.h>
> #else
> #include <asm/ucontext.h>
> diff --git a/arch/powerpc/perf/callchain_32.c b/arch/powerpc/perf/callchain_32.c
> index b83c47b7947f..ea8cfe3806dc 100644
> --- a/arch/powerpc/perf/callchain_32.c
> +++ b/arch/powerpc/perf/callchain_32.c
> @@ -19,7 +19,7 @@
> #include "callchain.h"
>
> #ifdef CONFIG_PPC64
> -#include "../kernel/ppc32.h"
> +#include <asm/syscalls_32.h>
> #else /* CONFIG_PPC64 */
>
> #define __SIGNAL_FRAMESIZE32 __SIGNAL_FRAMESIZE
> --
> 2.34.1
next prev parent reply other threads:[~2022-09-20 1:28 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 5:32 [PATCH 00/23] powerpc: Syscall wrapper and register clearing Rohan McLure
2022-09-16 5:32 ` [PATCH 01/23] powerpc: Remove asmlinkage from syscall handler definitions Rohan McLure
2022-09-16 5:32 ` [PATCH 02/23] powerpc: Save caller r3 prior to system_call_exception Rohan McLure
2022-09-16 5:32 ` [PATCH 03/23] powerpc: Add ZEROIZE_GPRS macros for register clears Rohan McLure
2022-09-16 5:32 ` [PATCH 04/23] powerpc/64s: Use {ZEROIZE,SAVE,REST}_GPRS macros in sc, scv 0 handlers Rohan McLure
2022-09-16 5:32 ` [PATCH 05/23] powerpc/32: Clarify interrupt restores with REST_GPR macro in entry_32.S Rohan McLure
2022-09-20 0:51 ` Nicholas Piggin
2022-09-16 5:32 ` [PATCH 06/23] powerpc/64e: Clarify register saves and clears with {SAVE,ZEROIZE}_GPRS Rohan McLure
2022-09-20 0:55 ` Nicholas Piggin
2022-09-16 5:32 ` [PATCH 07/23] powerpc/64s: Fix comment on interrupt handler prologue Rohan McLure
2022-09-20 0:55 ` Nicholas Piggin
2022-09-16 5:32 ` [PATCH 08/23] powerpc: Fix fallocate and fadvise64_64 compat parameter combination Rohan McLure
2022-09-16 6:54 ` Arnd Bergmann
2022-09-20 1:01 ` Nicholas Piggin
2022-09-16 5:32 ` [PATCH 09/23] asm-generic: compat: Support BE for long long args in 32-bit ABIs Rohan McLure
2022-09-20 1:06 ` Nicholas Piggin
2022-09-20 7:09 ` Arnd Bergmann
2022-09-16 5:32 ` [PATCH 10/23] powerpc: Use generic fallocate compatibility syscall Rohan McLure
2022-09-16 6:56 ` Arnd Bergmann
2022-09-16 5:32 ` [PATCH 11/23] powerpc/32: Remove powerpc select specialisation Rohan McLure
2022-09-16 5:32 ` [PATCH 12/23] powerpc: Remove direct call to personality syscall handler Rohan McLure
2022-09-16 5:32 ` [PATCH 13/23] powerpc: Remove direct call to mmap2 syscall handlers Rohan McLure
2022-09-16 5:32 ` [PATCH 14/23] powerpc: Provide do_ppc64_personality helper Rohan McLure
2022-09-16 5:32 ` [PATCH 15/23] powerpc: Adopt SYSCALL_DEFINE for arch-specific syscall handlers Rohan McLure
2022-09-16 5:48 ` Rohan McLure
2022-09-20 1:24 ` Nicholas Piggin
2022-09-16 5:32 ` [PATCH 16/23] powerpc: Include all arch-specific syscall prototypes Rohan McLure
2022-09-20 1:27 ` Nicholas Piggin [this message]
2022-09-16 5:32 ` [PATCH 17/23] powerpc: Enable compile-time check for syscall handlers Rohan McLure
2022-09-20 1:30 ` Nicholas Piggin
2022-09-16 5:32 ` [PATCH 18/23] powerpc: Use common syscall handler type Rohan McLure
2022-09-20 1:39 ` Nicholas Piggin
2022-09-16 5:32 ` [PATCH 19/23] powerpc: Provide syscall wrapper Rohan McLure
2022-09-20 1:59 ` Nicholas Piggin
2022-09-21 3:44 ` Rohan McLure
2022-09-16 5:32 ` [PATCH 20/23] powerpc/64s: Clear/restore caller gprs in syscall interrupt/return Rohan McLure
2022-09-20 2:03 ` Nicholas Piggin
2022-09-20 4:54 ` Rohan McLure
2022-09-21 5:33 ` Rohan McLure
2022-09-20 2:07 ` Nicholas Piggin
2022-09-16 5:32 ` [PATCH 21/23] powerpc/64: Add INTERRUPT_SANITIZE_REGISTERS Kconfig Rohan McLure
2022-09-20 2:10 ` Nicholas Piggin
2022-09-16 5:32 ` [PATCH 22/23] powerpc/64s: Clear gprs on interrupt routine entry in Book3S Rohan McLure
2022-09-20 2:27 ` Nicholas Piggin
2022-09-16 5:33 ` [PATCH 23/23] powerpc/64e: Clear gprs on interrupt routine entry on Book3E Rohan McLure
2022-09-16 5:58 ` [PATCH 00/23] powerpc: Syscall wrapper and register clearing Rohan McLure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CN0U6W1ZA0GA.1J34ZJPEE7J1D@bobo \
--to=npiggin@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rmclure@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox