From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"Guenter Roeck" <linux@roeck-us.net>
Cc: david@redhat.com, linux-kernel@vger.kernel.org,
wsa+renesas@sang-engineering.com, nicholas@linux.ibm.com,
windhl@126.com, cuigaosheng1@huawei.com, mikey@neuling.org,
paul@paul-moore.com, haren@linux.ibm.com, joel@jms.id.au,
lukas.bulwahn@gmail.com, nathanl@linux.ibm.com,
ajd@linux.ibm.com, ye.xingchen@zte.com.cn, nathan@kernel.org,
rmclure@linux.ibm.com, hbathini@linux.ibm.com,
atrajeev@linux.vnet.ibm.com, yuanjilin@cdjrlc.com,
pali@kernel.org, farosas@linux.ibm.com, geoff@infradead.org,
Linus Torvalds <torvalds@linux-foundation.org>,
gustavoars@kernel.org, lihuafei1@huawei.com,
aneesh.kumar@linux.ibm.com, zhengyongjun3@huawei.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.1-1 tag
Date: Thu, 13 Oct 2022 15:17:37 +1000 [thread overview]
Message-ID: <CNKJHFYTRLX9.1OXK4PSAZ6J28@bobo> (raw)
In-Reply-To: <Y0cJfoPLGeuzm/gQ@zx2c4.com>
On Thu Oct 13, 2022 at 4:37 AM AEST, Jason A. Donenfeld wrote:
> On Wed, Oct 12, 2022 at 10:48:26AM -0700, Guenter Roeck wrote:
> > > I've also managed to not hit this bug a few times. When it triggers,
> > > after "kprobes: kprobe jump-optimization is enabled. All kprobes are
> > > optimized if possible.", there's a long hang - tens seconds before it
> > > continues. When it doesn't trigger, there's no hang at that point in the
> > > boot process.
> > >
> >
> > That probably explains why my attempts to bisect the problem were
> > unsuccessful.
>
> So I just did this:
>
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 2fe28eeb2f38..2d70bc09db7e 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -1212,6 +1212,7 @@ static void __cold try_to_generate_entropy(void)
> struct entropy_timer_state stack;
> unsigned int i, num_different = 0;
> unsigned long last = random_get_entropy();
> + return;
>
> for (i = 0; i < NUM_TRIAL_SAMPLES - 1; ++i) {
> stack.entropy = random_get_entropy();
>
> And then ran it, and now we get the lockup from the idle process:
Yep that rules out the random code. And really if it was calling
schedule() it shouldn't be getting a softlockup anyway.
Thanks,
Nick
next prev parent reply other threads:[~2022-10-13 5:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 11:01 [GIT PULL] Please pull powerpc/linux.git powerpc-6.1-1 tag Michael Ellerman
2022-10-09 21:17 ` pr-tracker-bot
2022-10-10 19:25 ` Jason A. Donenfeld
2022-10-10 20:03 ` Jason A. Donenfeld
2022-10-10 22:26 ` Jason A. Donenfeld
2022-10-11 0:00 ` Andrew Donnellan
2022-10-11 0:13 ` Jason A. Donenfeld
2022-10-11 1:44 ` Michael Ellerman
2022-10-11 2:57 ` Jason A. Donenfeld
2022-10-11 9:34 ` Michael Ellerman
2022-10-11 1:53 ` Michael Ellerman
2022-10-11 2:57 ` Jason A. Donenfeld
2022-10-11 9:35 ` Michael Ellerman
2022-10-11 11:10 ` Nicholas Piggin
2022-10-12 14:18 ` Guenter Roeck
2022-10-12 15:49 ` Jason A. Donenfeld
2022-10-12 16:44 ` Guenter Roeck
2022-10-12 17:20 ` Jason A. Donenfeld
2022-10-12 17:48 ` Guenter Roeck
2022-10-12 18:37 ` Jason A. Donenfeld
2022-10-13 5:17 ` Nicholas Piggin [this message]
2022-10-12 22:16 ` Guenter Roeck
2022-10-13 0:03 ` Michael Ellerman
2022-10-13 0:21 ` Guenter Roeck
2022-10-13 5:03 ` Nicholas Piggin
2022-10-13 5:19 ` Jason A. Donenfeld
2022-10-13 5:20 ` Guenter Roeck
2022-10-13 5:22 ` Nicholas Piggin
2022-10-13 4:43 ` Guenter Roeck
2022-10-13 5:14 ` Nicholas Piggin
2022-10-13 18:55 ` Guenter Roeck
2022-10-12 16:45 ` Jason A. Donenfeld
2022-10-12 16:49 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CNKJHFYTRLX9.1OXK4PSAZ6J28@bobo \
--to=npiggin@gmail.com \
--cc=Jason@zx2c4.com \
--cc=ajd@linux.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=cuigaosheng1@huawei.com \
--cc=david@redhat.com \
--cc=farosas@linux.ibm.com \
--cc=geoff@infradead.org \
--cc=gustavoars@kernel.org \
--cc=haren@linux.ibm.com \
--cc=hbathini@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=lihuafei1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mikey@neuling.org \
--cc=nathan@kernel.org \
--cc=nathanl@linux.ibm.com \
--cc=nicholas@linux.ibm.com \
--cc=pali@kernel.org \
--cc=paul@paul-moore.com \
--cc=rmclure@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=windhl@126.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=ye.xingchen@zte.com.cn \
--cc=yuanjilin@cdjrlc.com \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox