From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Thomas Huth" <thuth@redhat.com>, <kvm@vger.kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Sean Christopherson" <seanjc@google.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Marc Zyngier <maz@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-kernel@vger.kernel.org,
Oliver Upton <oliver.upton@linux.dev>,
kvmarm@lists.linux.dev, James Morse <james.morse@arm.com>,
kvm-riscv@lists.infradead.org, Zenghui Yu <yuzenghui@huawei.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/7] KVM: PPC: Standardize on "int" return types in the powerpc KVM code
Date: Fri, 03 Feb 2023 20:21:55 +1000 [thread overview]
Message-ID: <CQ8UPZX0BERP.2TFM4914IGJZF@bobo> (raw)
In-Reply-To: <20230203094230.266952-5-thuth@redhat.com>
On Fri Feb 3, 2023 at 7:42 PM AEST, Thomas Huth wrote:
> Most functions that are related to kvm_arch_vm_ioctl() already use
> "int" as return type to pass error values back to the caller. Some
> outlier functions use "long" instead for no good reason (they do not
> really require long values here). Let's standardize on "int" here to
> avoid casting the values back and forth between the two types.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks for the patch. It looks fine to me, it should be okay to
go via Paolo's tree if he's going to take the series.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> arch/powerpc/include/asm/kvm_ppc.h | 14 +++++++-------
> arch/powerpc/kvm/book3s_64_mmu_hv.c | 14 +++++++-------
> arch/powerpc/kvm/book3s_64_vio.c | 4 ++--
> arch/powerpc/kvm/book3s_hv.c | 6 +++---
> arch/powerpc/kvm/book3s_pr.c | 4 ++--
> 5 files changed, 21 insertions(+), 21 deletions(-)
next prev parent reply other threads:[~2023-02-03 10:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 9:42 [PATCH 0/7] KVM: Standardize on "int" return types instead of "long" Thomas Huth
2023-02-03 9:42 ` [PATCH 1/7] KVM: Standardize on "int" return types instead of "long" in kvm_main.c Thomas Huth
2023-02-03 9:42 ` [PATCH 2/7] KVM: x86: Improve return type handling in kvm_vm_ioctl_get_nr_mmu_pages() Thomas Huth
2023-02-03 17:48 ` Sean Christopherson
2023-02-07 9:26 ` Thomas Huth
2023-02-07 16:25 ` Sean Christopherson
2023-02-03 9:42 ` [PATCH 3/7] KVM: Move KVM_GET_NR_MMU_PAGES into the deprecation section Thomas Huth
2023-02-03 10:16 ` Nicholas Piggin
2023-02-03 10:54 ` Thomas Huth
2023-02-03 9:42 ` [PATCH 4/7] KVM: PPC: Standardize on "int" return types in the powerpc KVM code Thomas Huth
2023-02-03 10:21 ` Nicholas Piggin [this message]
2023-02-03 9:42 ` [PATCH 5/7] KVM: s390: Use "int" as return type for kvm_s390_get/set_skeys() Thomas Huth
2023-02-07 15:36 ` Claudio Imbrenda
2023-02-03 9:42 ` [PATCH 6/7] KVM: arm64: Change return type of kvm_vm_ioctl_mte_copy_tags() to "int" Thomas Huth
2023-02-07 0:09 ` Gavin Shan
2023-02-07 10:09 ` Thomas Huth
2023-02-07 22:16 ` Gavin Shan
2023-02-08 8:49 ` Cornelia Huck
2023-02-08 11:51 ` Steven Price
2023-02-08 12:16 ` Thomas Huth
2023-02-03 9:42 ` [PATCH 7/7] KVM: Change return type of kvm_arch_vm_ioctl() " Thomas Huth
2023-02-08 17:35 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CQ8UPZX0BERP.2TFM4914IGJZF@bobo \
--to=npiggin@gmail.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=james.morse@arm.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=suzuki.poulose@arm.com \
--cc=thuth@redhat.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).