From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EA81C54E4A for ; Thu, 7 Mar 2024 20:12:11 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dwYf4VUQ; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TrL7G11Xyz3vgl for ; Fri, 8 Mar 2024 07:12:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dwYf4VUQ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=jarkko@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TrL6S01rRz3dfy for ; Fri, 8 Mar 2024 07:11:27 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E59ACCE24FD; Thu, 7 Mar 2024 20:11:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BAC9C433A6; Thu, 7 Mar 2024 20:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709842285; bh=PRBFZzxdnpbyh1YzxY3vy1NxVesh8HXasBP1ah/s4Iw=; h=Date:To:Cc:Subject:From:References:In-Reply-To:From; b=dwYf4VUQ+8MNiFFZOdC5+Xg2Q6c6ZutnWss0KZMLp8KlC8GDhhSlnMpJbLNM/z6eV IlXT0LgZE000dtOPKKG4nUzX4daZFcfjq81v3Z2KL6poa6s+aKSM9Y6zXp83bb1oLX vf7H/wbVBC1SkcE1cV7c9XRVVcThE2GaFeAGxtKYgQAXvMLpJQC7lJuxf8znez1+nG tE2kFPtPqel/nooorKOw1X+MuvznCTPh8UYE29mc4gbm6Th3I4tei7YmQXbyFngbKC w/rlOojq3q9qQKvHj/LjNM7A0cm2xCrnL1WjF0nXIo0td7VBd5cfIXxpPvmqxgA+tQ kHDV8NBkmu/hw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 07 Mar 2024 22:11:21 +0200 Message-Id: To: "Stefan Berger" , , , Subject: Re: [PATCH 1/2] powerpc/prom_init: Replace linux,sml-base/sml-size with linux,sml-log From: "Jarkko Sakkinen" X-Mailer: aerc 0.17.0 References: <20240306155511.974517-1-stefanb@linux.ibm.com> <20240306155511.974517-2-stefanb@linux.ibm.com> In-Reply-To: <20240306155511.974517-2-stefanb@linux.ibm.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peterhuewe@gmx.de, viparash@in.ibm.com, linux-kernel@vger.kernel.org, rnsastry@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed Mar 6, 2024 at 5:55 PM EET, Stefan Berger wrote: > linux,sml-base holds the address of a buffer with the TPM log. This > buffer may become invalid after a kexec and therefore embed the whole TPM > log in linux,sml-log. This helps to protect the log since it is properly > carried across a kexec with both of the kexec syscalls. So, I see only description of the problem but nothing how it gets addressed. > > Signed-off-by: Stefan Berger > --- > arch/powerpc/kernel/prom_init.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_i= nit.c > index e67effdba85c..41268c30de4c 100644 > --- a/arch/powerpc/kernel/prom_init.c > +++ b/arch/powerpc/kernel/prom_init.c > @@ -1956,12 +1956,8 @@ static void __init prom_instantiate_sml(void) > =20 > reserve_mem(base, size); > =20 > - prom_setprop(ibmvtpm_node, "/vdevice/vtpm", "linux,sml-base", > - &base, sizeof(base)); > - prom_setprop(ibmvtpm_node, "/vdevice/vtpm", "linux,sml-size", > - &size, sizeof(size)); > - > - prom_debug("sml base =3D 0x%llx\n", base); > + prom_setprop(ibmvtpm_node, "/vdevice/vtpm", "linux,sml-log", > + (void *)base, size); > prom_debug("sml size =3D 0x%x\n", size); > =20 > prom_debug("prom_instantiate_sml: end...\n"); BR, Jarkko