From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AABCAC25B74 for ; Tue, 4 Jun 2024 05:14:21 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=R/SZlq65; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Vtf0C1XHnz3cLL for ; Tue, 4 Jun 2024 15:14:19 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=R/SZlq65; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::630; helo=mail-pl1-x630.google.com; envelope-from=npiggin@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VtdzL55SPz3bnL for ; Tue, 4 Jun 2024 15:13:33 +1000 (AEST) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1f62fae8c1aso33041575ad.3 for ; Mon, 03 Jun 2024 22:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717478011; x=1718082811; darn=lists.ozlabs.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GT7SfBTLOwpc/YXnH4XWcLEq77fXjMD17/6UtGiAP8o=; b=R/SZlq65mxCJgA4gErbOD/WXreTtB9S78K+jrq2HpVKyBdVHxeKH267qAk0djbfjqw PybVNfzkZ0a1AxzSJsPdyKDFqKBegSGazUJs5gTIExjM5VgqIOEwPb16bC+64EQ/0KAl nXr8ttt9UQk83Pdl50eV1wZ/xqKRaITEbAuFoHgy/Nf2EwV0SgRUZbrwmiKzR7sydWTX A9uLfKS6c5UgFkmzTboQgQ8DgOymgm29W3OWIz9zfMlxmrvb/DK7IsqOIK2/jFrFlhIz STYPfyOsMOCp0vddlUgMjGT5iepllVOuA0WVPW6aSm9oCMIFvTLXkzG2C7iWMfHleCDU BcMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717478011; x=1718082811; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GT7SfBTLOwpc/YXnH4XWcLEq77fXjMD17/6UtGiAP8o=; b=AhIYXFmxql8+I7la5rq5Ampz8PyYtGzZ19I424TwZTAHBI+UEgXsN3lqOS+EjQjyts kbMJP+njbeWa084TPF3MF94q0TKGY1H858femz4Zgjhnhmk8EnsYb6MOg42gE+ZUBxOi /jLDgFuT+bH0qMU/JXXeaeOKGq0BW/20ucMUP/WaUhfS50hTPeQhyaqhERfNC+Mvpsho 5i8ZoF9/FyxOMKDW51PmhmusG8thAOzsvA2ojphbxuSaCkHAEl6VY9Bv3l+jn47OvhaZ Bznrs5FLTvRLAt+nbdA7FLcmIb9YTnAhrkZ4zpQ7aNzAqndibuAjCq+oVYZ1nF0Rmbbc QFFQ== X-Forwarded-Encrypted: i=1; AJvYcCWFNMJBxQNpH+/lZ1ZFTcexjnL9OJASVJ4r/f8ANOJ9xINcw6UGR7L1APD2xY5yZqCleyjyKIbW4HavqNflHwYzjnZoenM84maw9D4l2Q== X-Gm-Message-State: AOJu0YxEsOf15M4Pt2jgqRShOYfPEuevpNTDBPCnzOkY5GPheuri/pgB SxOyPZQpcFwxz+hP95gWpcaYxP702hk4kw50N1q/Wt+mvIB/WgtX X-Google-Smtp-Source: AGHT+IFKbc5LjfirCcL45hrRasbp0xZlyYx9lCORURuAdAoEsU4e3Bn/DyFE6rfUbq7e8XuWC9Sp8w== X-Received: by 2002:a17:903:1109:b0:1f4:b7ff:ac4a with SMTP id d9443c01a7336-1f6370453a9mr122074735ad.37.1717478011071; Mon, 03 Jun 2024 22:13:31 -0700 (PDT) Received: from localhost ([1.146.11.115]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6323dd918sm73910735ad.164.2024.06.03.22.13.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 22:13:30 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 04 Jun 2024 15:13:26 +1000 Message-Id: To: "Thomas Huth" Subject: Re: [kvm-unit-tests PATCH v9 14/31] powerpc: Remove broken SMP exception stack setup From: "Nicholas Piggin" X-Mailer: aerc 0.17.0 References: <20240504122841.1177683-1-npiggin@gmail.com> <20240504122841.1177683-15-npiggin@gmail.com> <7059d458-048a-40a5-b21e-4e15568d1f54@redhat.com> In-Reply-To: <7059d458-048a-40a5-b21e-4e15568d1f54@redhat.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Andrew Jones Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon Jun 3, 2024 at 7:30 PM AEST, Thomas Huth wrote: > On 04/05/2024 14.28, Nicholas Piggin wrote: > > The exception stack setup does not work correctly for SMP, because > > it is the boot processor that calls cpu_set() which sets SPRG2 to > > the exception stack, not the target CPU itself. So secondaries > > never got their SPRG2 set to a valid exception stack. > > So secondary CPUs currently must not run into any exceptions? Yes, at the moment. It was broken anyway. Patch 16 creates a proper environment for secondaries, including taking interrupts. Thanks, Nick > > > Remove the SMP code and just set an exception stack for the boot > > processor. Make the stack 64kB while we're here, to match the > > size of the regular stack. > >=20 > > Signed-off-by: Nicholas Piggin > > --- > > lib/powerpc/setup.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > Reviewed-by: Thomas Huth