From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7E99C3DA64 for ; Wed, 31 Jul 2024 21:19:00 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=AwLJ4Sfu; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WZ4hz0FKDz3dFH for ; Thu, 1 Aug 2024 07:18:59 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=AwLJ4Sfu; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=jarkko@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WZ4hC21CMz3cVW for ; Thu, 1 Aug 2024 07:18:19 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9C25FCE122C; Wed, 31 Jul 2024 21:18:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70117C116B1; Wed, 31 Jul 2024 21:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722460695; bh=Iz5fv2WGX9mZwr+ta4iHBVQHKmHWtOfb0ViE/BWikcQ=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=AwLJ4SfuaWViCPkLovq03bs+6GgDObgFFcwCS7PiyRpvLe/IqWgEDAhl9+CpN8uFK 5N/JGUJnBgWxzkjxivgZ+TE3+/0oMbdGwVSYdEuB5iGkJ7v0e94Jz1fogvCrywjKVx JVPvIzZF5Cxpvbmc2+Er4Dy9tmS6Fh7P+xw5+RxLJjSqnkTtLgk+wZncvUB9u+z3Wb 2dWqleW3WTevbFWStJoywR/hx1eLJHwz8vbMVhnFFD5Rci2i3Br9iVrBMjLowPVorm B3YxpwimHplu5BDyx6380bD6N9G8F+Oz06cuN/EgRQQjete97Ysv5LQDXQnzOffx4a qFqzGyyVIOY7A== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 01 Aug 2024 00:18:11 +0300 Message-Id: Subject: Re: [PATCH v2] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support From: "Jarkko Sakkinen" To: "Stefan Berger" , , X-Mailer: aerc 0.18.0 References: <20240729132934.311136-1-stefanb@linux.ibm.com> In-Reply-To: <20240729132934.311136-1-stefanb@linux.ibm.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: naveen.n.rao@linux.ibm.com, linux-kernel@vger.kernel.org, zohar@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon Jul 29, 2024 at 4:29 PM EEST, Stefan Berger wrote: > Commit d2add27cf2b8 ("tpm: Add NULL primary creation") introduced > CONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the > following message appears in the kernel log due to a missing call to > tpm2_sessions_init(). > > [ 2.654549] tpm tpm0: auth session is not active > > Add the missing call to tpm2_session_init() to the ibmvtpm driver to > resolve this issue. > > Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation") > Signed-off-by: Stefan Berger > --- > drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtp= m.c > index d3989b257f42..1e5b107d1f3b 100644 > --- a/drivers/char/tpm/tpm_ibmvtpm.c > +++ b/drivers/char/tpm/tpm_ibmvtpm.c > @@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev= , > rc =3D tpm2_get_cc_attrs_tbl(chip); > if (rc) > goto init_irq_cleanup; > + > + rc =3D tpm2_sessions_init(chip); > + if (rc) > + goto init_irq_cleanup; > } > =20 > return tpm_chip_register(chip); Cannot get emails working with my Linux machine given https://bugzilla.redhat.com/show_bug.cgi?id=3D2302132 I'll try to sort this out first and then do a pull request. BR, Jarkko