linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Kexy Biscuit" <kexybiscuit@aosc.io>, <stefanb@linux.ibm.com>,
	<linux-integrity@vger.kernel.org>,
	<linuxppc-dev@lists.ozlabs.org>
Cc: <linux-kernel@vger.kernel.org>, <mpe@ellerman.id.au>,
	<naveen.n.rao@linux.ibm.com>, <zohar@linux.ibm.com>,
	<stable@vger.kernel.org>, "kernel test robot" <lkp@intel.com>,
	"Mingcong Bai" <jeffbai@aosc.io>
Subject: Re: [PATCH v2 RESEND] tpm: export tpm2_sessions_init() to fix ibmvtpm building
Date: Thu, 05 Sep 2024 17:26:17 +0300	[thread overview]
Message-ID: <D3YF52E4EVJ0.2ZJSCR5FCVIGX@kernel.org> (raw)
In-Reply-To: <20240905085219.77240-2-kexybiscuit@aosc.io>

On Thu Sep 5, 2024 at 11:52 AM EEST, Kexy Biscuit wrote:
> Commit 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to
> initialize session support") adds call to tpm2_sessions_init() in ibmvtpm,
> which could be built as a module. However, tpm2_sessions_init() wasn't
> exported, causing libmvtpm to fail to build as a module:
>
> ERROR: modpost: "tpm2_sessions_init" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
>
> Export tpm2_sessions_init() to resolve the issue.
>
> Cc: stable@vger.kernel.org # v6.10+
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202408051735.ZJkAPQ3b-lkp@intel.com/
> Fixes: 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support")
> Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
> Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
> ---
> V1 -> V2: Added Fixes tag and fixed email format
> RESEND: The previous email was sent directly to stable-rc review
>
>  drivers/char/tpm/tpm2-sessions.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm2-sessions.c b/drivers/char/tpm/tpm2-sessions.c
> index d3521aadd43e..44f60730cff4 100644
> --- a/drivers/char/tpm/tpm2-sessions.c
> +++ b/drivers/char/tpm/tpm2-sessions.c
> @@ -1362,4 +1362,5 @@ int tpm2_sessions_init(struct tpm_chip *chip)
>  
>  	return rc;
>  }
> +EXPORT_SYMBOL(tpm2_sessions_init);
>  #endif /* CONFIG_TCG_TPM2_HMAC */

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko


  reply	other threads:[~2024-09-05 14:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05  8:52 [PATCH v2 RESEND] tpm: export tpm2_sessions_init() to fix ibmvtpm building Kexy Biscuit
2024-09-05 14:26 ` Jarkko Sakkinen [this message]
2024-09-06 17:02   ` Stefan Berger
2024-09-06 17:36     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D3YF52E4EVJ0.2ZJSCR5FCVIGX@kernel.org \
    --to=jarkko@kernel.org \
    --cc=jeffbai@aosc.io \
    --cc=kexybiscuit@aosc.io \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lkp@intel.com \
    --cc=mpe@ellerman.id.au \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=stable@vger.kernel.org \
    --cc=stefanb@linux.ibm.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).