* [PATCH v2 RESEND] tpm: export tpm2_sessions_init() to fix ibmvtpm building
@ 2024-09-05 8:52 Kexy Biscuit
2024-09-05 14:26 ` Jarkko Sakkinen
0 siblings, 1 reply; 4+ messages in thread
From: Kexy Biscuit @ 2024-09-05 8:52 UTC (permalink / raw)
To: stefanb, jarkko, linux-integrity, linuxppc-dev
Cc: linux-kernel, mpe, naveen.n.rao, zohar, Kexy Biscuit, stable,
kernel test robot, Mingcong Bai
Commit 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to
initialize session support") adds call to tpm2_sessions_init() in ibmvtpm,
which could be built as a module. However, tpm2_sessions_init() wasn't
exported, causing libmvtpm to fail to build as a module:
ERROR: modpost: "tpm2_sessions_init" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
Export tpm2_sessions_init() to resolve the issue.
Cc: stable@vger.kernel.org # v6.10+
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202408051735.ZJkAPQ3b-lkp@intel.com/
Fixes: 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support")
Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
---
V1 -> V2: Added Fixes tag and fixed email format
RESEND: The previous email was sent directly to stable-rc review
drivers/char/tpm/tpm2-sessions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/tpm2-sessions.c b/drivers/char/tpm/tpm2-sessions.c
index d3521aadd43e..44f60730cff4 100644
--- a/drivers/char/tpm/tpm2-sessions.c
+++ b/drivers/char/tpm/tpm2-sessions.c
@@ -1362,4 +1362,5 @@ int tpm2_sessions_init(struct tpm_chip *chip)
return rc;
}
+EXPORT_SYMBOL(tpm2_sessions_init);
#endif /* CONFIG_TCG_TPM2_HMAC */
--
2.46.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 RESEND] tpm: export tpm2_sessions_init() to fix ibmvtpm building
2024-09-05 8:52 [PATCH v2 RESEND] tpm: export tpm2_sessions_init() to fix ibmvtpm building Kexy Biscuit
@ 2024-09-05 14:26 ` Jarkko Sakkinen
2024-09-06 17:02 ` Stefan Berger
0 siblings, 1 reply; 4+ messages in thread
From: Jarkko Sakkinen @ 2024-09-05 14:26 UTC (permalink / raw)
To: Kexy Biscuit, stefanb, linux-integrity, linuxppc-dev
Cc: linux-kernel, mpe, naveen.n.rao, zohar, stable, kernel test robot,
Mingcong Bai
On Thu Sep 5, 2024 at 11:52 AM EEST, Kexy Biscuit wrote:
> Commit 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to
> initialize session support") adds call to tpm2_sessions_init() in ibmvtpm,
> which could be built as a module. However, tpm2_sessions_init() wasn't
> exported, causing libmvtpm to fail to build as a module:
>
> ERROR: modpost: "tpm2_sessions_init" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
>
> Export tpm2_sessions_init() to resolve the issue.
>
> Cc: stable@vger.kernel.org # v6.10+
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202408051735.ZJkAPQ3b-lkp@intel.com/
> Fixes: 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support")
> Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
> Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
> ---
> V1 -> V2: Added Fixes tag and fixed email format
> RESEND: The previous email was sent directly to stable-rc review
>
> drivers/char/tpm/tpm2-sessions.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm2-sessions.c b/drivers/char/tpm/tpm2-sessions.c
> index d3521aadd43e..44f60730cff4 100644
> --- a/drivers/char/tpm/tpm2-sessions.c
> +++ b/drivers/char/tpm/tpm2-sessions.c
> @@ -1362,4 +1362,5 @@ int tpm2_sessions_init(struct tpm_chip *chip)
>
> return rc;
> }
> +EXPORT_SYMBOL(tpm2_sessions_init);
> #endif /* CONFIG_TCG_TPM2_HMAC */
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 RESEND] tpm: export tpm2_sessions_init() to fix ibmvtpm building
2024-09-05 14:26 ` Jarkko Sakkinen
@ 2024-09-06 17:02 ` Stefan Berger
2024-09-06 17:36 ` Jarkko Sakkinen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Berger @ 2024-09-06 17:02 UTC (permalink / raw)
To: Jarkko Sakkinen, Kexy Biscuit, linux-integrity, linuxppc-dev
Cc: linux-kernel, mpe, naveen.n.rao, zohar, stable, kernel test robot,
Mingcong Bai
On 9/5/24 10:26 AM, Jarkko Sakkinen wrote:
> On Thu Sep 5, 2024 at 11:52 AM EEST, Kexy Biscuit wrote:
>> Commit 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to
>> initialize session support") adds call to tpm2_sessions_init() in ibmvtpm,
>> which could be built as a module. However, tpm2_sessions_init() wasn't
>> exported, causing libmvtpm to fail to build as a module:
>>
>> ERROR: modpost: "tpm2_sessions_init" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
>>
>> Export tpm2_sessions_init() to resolve the issue.
>>
>> Cc: stable@vger.kernel.org # v6.10+
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202408051735.ZJkAPQ3b-lkp@intel.com/
>> Fixes: 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support")
>> Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
>> Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
>> ---
>> V1 -> V2: Added Fixes tag and fixed email format
>> RESEND: The previous email was sent directly to stable-rc review
>>
>> drivers/char/tpm/tpm2-sessions.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/char/tpm/tpm2-sessions.c b/drivers/char/tpm/tpm2-sessions.c
>> index d3521aadd43e..44f60730cff4 100644
>> --- a/drivers/char/tpm/tpm2-sessions.c
>> +++ b/drivers/char/tpm/tpm2-sessions.c
>> @@ -1362,4 +1362,5 @@ int tpm2_sessions_init(struct tpm_chip *chip)
>>
>> return rc;
>> }
>> +EXPORT_SYMBOL(tpm2_sessions_init);
>> #endif /* CONFIG_TCG_TPM2_HMAC */
>
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
>
Would have tested it but machine is down..
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> BR, Jarkko
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 RESEND] tpm: export tpm2_sessions_init() to fix ibmvtpm building
2024-09-06 17:02 ` Stefan Berger
@ 2024-09-06 17:36 ` Jarkko Sakkinen
0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2024-09-06 17:36 UTC (permalink / raw)
To: Stefan Berger, Kexy Biscuit, linux-integrity, linuxppc-dev
Cc: linux-kernel, mpe, naveen.n.rao, zohar, stable, kernel test robot,
Mingcong Bai
On Fri Sep 6, 2024 at 8:02 PM EEST, Stefan Berger wrote:
>
>
> On 9/5/24 10:26 AM, Jarkko Sakkinen wrote:
> > On Thu Sep 5, 2024 at 11:52 AM EEST, Kexy Biscuit wrote:
> >> Commit 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to
> >> initialize session support") adds call to tpm2_sessions_init() in ibmvtpm,
> >> which could be built as a module. However, tpm2_sessions_init() wasn't
> >> exported, causing libmvtpm to fail to build as a module:
> >>
> >> ERROR: modpost: "tpm2_sessions_init" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
> >>
> >> Export tpm2_sessions_init() to resolve the issue.
> >>
> >> Cc: stable@vger.kernel.org # v6.10+
> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Closes: https://lore.kernel.org/oe-kbuild-all/202408051735.ZJkAPQ3b-lkp@intel.com/
> >> Fixes: 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support")
> >> Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
> >> Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
> >> ---
> >> V1 -> V2: Added Fixes tag and fixed email format
> >> RESEND: The previous email was sent directly to stable-rc review
> >>
> >> drivers/char/tpm/tpm2-sessions.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/char/tpm/tpm2-sessions.c b/drivers/char/tpm/tpm2-sessions.c
> >> index d3521aadd43e..44f60730cff4 100644
> >> --- a/drivers/char/tpm/tpm2-sessions.c
> >> +++ b/drivers/char/tpm/tpm2-sessions.c
> >> @@ -1362,4 +1362,5 @@ int tpm2_sessions_init(struct tpm_chip *chip)
> >>
> >> return rc;
> >> }
> >> +EXPORT_SYMBOL(tpm2_sessions_init);
> >> #endif /* CONFIG_TCG_TPM2_HMAC */
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> >
> Would have tested it but machine is down..
>
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
I'll add this before the PR, thank you.
BR, Jarkko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-06 22:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-05 8:52 [PATCH v2 RESEND] tpm: export tpm2_sessions_init() to fix ibmvtpm building Kexy Biscuit
2024-09-05 14:26 ` Jarkko Sakkinen
2024-09-06 17:02 ` Stefan Berger
2024-09-06 17:36 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).