From: Kumar Gala <galak@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/85xx: Update smp support to handle doorbells and non-mpic init
Date: Wed, 11 Mar 2009 12:35:25 -0500 [thread overview]
Message-ID: <D46633DA-CDC6-4E38-8424-B62A18FDB361@kernel.crashing.org> (raw)
In-Reply-To: <20090311155242.GA11120@ld0162-tx32.am.freescale.net>
On Mar 11, 2009, at 10:52 AM, Scott Wood wrote:
> On Wed, Mar 11, 2009 at 06:46:03AM -0500, Kumar Gala wrote:
>> +void __init mpc85xx_smp_init(void)
>> +{
>> + struct device_node *np;
>> +
>> + smp_85xx_ops.message_pass = NULL;
>> +
>> + np = of_find_node_by_type(NULL, "open-pic");
>
> We should probably look by compatible rather than device_type. I see
> only one device tree that has the latter but not the former (ksi8560),
> and it's not SMP (but should still be fixed, of course).
Ever other lookup for the mpic node is done by type. I see no reason
to change this right now.
- k
prev parent reply other threads:[~2009-03-11 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 11:46 [PATCH] powerpc/85xx: Update smp support to handle doorbells and non-mpic init Kumar Gala
2009-03-11 15:52 ` Scott Wood
2009-03-11 17:35 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D46633DA-CDC6-4E38-8424-B62A18FDB361@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox