From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <45903308677306428B6EE7E6FF5A52041419B6@039-SN1MPN1-004.039d.mgd.msft.net> Date: Thu, 23 Jun 2011 05:27:52 -0500 Message-Id: References: <1307501379-3160-1-git-send-email-prabhakar@freescale.com> <45903308677306428B6EE7E6FF5A52041419B6@039-SN1MPN1-004.039d.mgd.msft.net> To: Aggrwal Poonam-B10812 Cc: "meet2prabhu@gmail.com" , "devicetree-discuss@lists.ozlabs.org" , "linuxppc-dev@lists.ozlabs.org" , Kushwaha Prabhakar-B32579 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Jun 23, 2011, at 2:24 AM, Aggrwal Poonam-B10812 wrote: >=20 >=20 >> -----Original Message----- >> From: = linuxppc-dev-bounces+poonam.aggrwal=3Dfreescale.com@lists.ozlabs.org >> [mailto:linuxppc-dev- >> bounces+poonam.aggrwal=3Dfreescale.com@lists.ozlabs.org] On Behalf Of = Kumar >> Gala >> Sent: Wednesday, June 22, 2011 5:04 PM >> To: Kushwaha Prabhakar-B32579 >> Cc: meet2prabhu@gmail.com; devicetree-discuss@lists.ozlabs.org; = linuxppc- >> dev@lists.ozlabs.org >> Subject: Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for = Px020RDB >>=20 >>=20 >> On Jun 7, 2011, at 9:49 PM, Prabhakar Kushwaha wrote: >>=20 >>> ten-bit interface (TBI) module is part of SoC not board. >>>=20 >>> Move tbi entries from board related dts files to Si dts. >>>=20 >>> Signed-off-by: Prabhakar Kushwaha >>> --- >>> Based upon >> http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git = (branch >> next) >>>=20 >>> arch/powerpc/boot/dts/p1020rdb.dts | 9 --------- >>> arch/powerpc/boot/dts/p1020rdb_camp_core0.dts | 8 -------- >>> arch/powerpc/boot/dts/p1020si.dtsi | 6 +++++- >>> arch/powerpc/boot/dts/p2020rdb.dts | 8 -------- >>> arch/powerpc/boot/dts/p2020rdb_camp_core0.dts | 8 -------- >>> arch/powerpc/boot/dts/p2020si.dtsi | 6 +++++- >>> 6 files changed, 10 insertions(+), 35 deletions(-) >>>=20 >>> diff --git a/arch/powerpc/boot/dts/p1020rdb.dts >> b/arch/powerpc/boot/dts/p1020rdb.dts >>> index d6a8ae4..a4e5d6c 100644 >>> --- a/arch/powerpc/boot/dts/p1020rdb.dts >>> +++ b/arch/powerpc/boot/dts/p1020rdb.dts >>> @@ -211,14 +211,6 @@ >>> }; >>> }; >>>=20 >>> - mdio@25000 { >>> - >>> - tbi0: tbi-phy@11 { >>> - reg =3D <0x11>; >>> - device_type =3D "tbi-phy"; >>> - }; >>> - }; >>> - >>> enet0: ethernet@b0000 { >>> fixed-link =3D <1 1 1000 0 0>; >>> phy-connection-type =3D "rgmii-id"; >>> @@ -227,7 +219,6 @@ >>>=20 >>> enet1: ethernet@b1000 { >>> phy-handle =3D <&phy0>; >>> - tbi-handle =3D <&tbi0>; >>> phy-connection-type =3D "sgmii"; >>>=20 >>> }; >>=20 >> I'm not sure we should do this. The phy address we pick is board >> specific so it should NOT be in .dtsi > The TBI phy and it's address is internal to SOC. But it is configured to NOT conflict with external PHY addresses. This = the setting is board specific in my opinion. - k=