From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <segher@kernel.crashing.org>
Received: from mail-in-03.arcor-online.net (mail-in-03.arcor-online.net
	[151.189.21.43])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mx.arcor.de",
	Issuer "Thawte Premium Server CA" (verified OK))
	by ozlabs.org (Postfix) with ESMTP id 5894E67EDA
	for <linuxppc-dev@ozlabs.org>; Sat,  7 Oct 2006 08:37:12 +1000 (EST)
In-Reply-To: <1160170142.22232.132.camel@localhost.localdomain>
References: <1160113201.22232.112.camel@localhost.localdomain>
	<64BDCE50-03D6-44BA-97EA-AA4AE5B53F32@kernel.crashing.org>
	<1160170142.22232.132.camel@localhost.localdomain>
Mime-Version: 1.0 (Apple Message framework v752.2)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <DA809761-6800-486F-9549-E55CD40843DD@kernel.crashing.org>
From: Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH] powerpc: make U4 PCIe work (#2)
Date: Sat, 7 Oct 2006 00:37:05 +0200
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

>>> +static unsigned int u4_pcie_cfa0(u8 devfn, u8 off)
>>
>> "off" should be bigger than u8...
>
> Right
>
>>> +{
>>> +	return (1 << ((unsigned int)PCI_SLOT(devfn))) 	|
>>> +		(((unsigned int)PCI_FUNC(devfn)) << 8) |
>>> +		((((unsigned int)(off)) >> 8) << 28) 	|
>>
>> ...and the compiler told you about that here.
>
> No it didn't...

Ah right, because of the explicit cast.  Get rid of it :-)

>> Make the parameters and return value all u32 and you won't
>> need casts anymore, the function call will implicitly do it.


Segher