From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: In-Reply-To: <989B956029373F45A0B8AF0297081890019B5C7A@zch01exm26.fsl.freescale.net> References: <1192702580-6353-1-git-send-email-leoli@freescale.com> <20071019005613.GA18240@localhost.localdomain> <989B956029373F45A0B8AF0297081890019B5C7A@zch01exm26.fsl.freescale.net> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: From: Kumar Gala Subject: Re: [PATCH v5 9/9] add MPC837x MDS board default device tree Date: Fri, 19 Oct 2007 08:10:50 -0500 To: Li Yang-r58472 Cc: linuxppc-dev@ozlabs.org, Phillips Kim-R1AAHA , paulus@samba.org, David Gibson List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Oct 19, 2007, at 2:31 AM, Li Yang-r58472 wrote: >> -----Original Message----- >> From: David Gibson [mailto:david@gibson.dropbear.id.au] >> Sent: Friday, October 19, 2007 8:56 AM >> To: Li Yang-r58472 >> Cc: galak@kernel.crashing.org; paulus@samba.org; >> linuxppc-dev@ozlabs.org >> Subject: Re: [PATCH v5 9/9] add MPC837x MDS board default device tree >> >> On Thu, Oct 18, 2007 at 06:16:20PM +0800, Li Yang wrote: >>> Signed-off-by: Li Yang >>> --- >>> diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts >>> b/arch/powerpc/boot/dts/mpc8377_mds.dts >>> new file mode 100644 >>> index 0000000..8530de6 >>> --- /dev/null >>> +++ b/arch/powerpc/boot/dts/mpc8377_mds.dts >>> @@ -0,0 +1,282 @@ >> [snip] >>> + crypto@30000 { >>> + model = "SEC3"; >>> + compatible = "talitos"; >> >> That compatible doesn't look specific enough. It should at >> least have a vendor portion. In general it's best to have >> all the information you need to pick a driver and options in >> compatible, rather than splitting that info into model. > > I think we could do this in a separate patch. Change the spec and > then > update all the in-tree device tree with SEC node. agreed. - k