From: "Rune Torgersen" <runet@innovsys.com>
To: <linuxppc-embedded@ozlabs.org>
Subject: [PATCH] FCC Ethernet startup crash
Date: Thu, 7 Apr 2005 14:22:17 -0500 [thread overview]
Message-ID: <DCEAAC0833DD314AB0B58112AD99B93B859341@ismail.innsys.innovsys.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
This patch fizxes a race condition in the FCC ethernet driver, where the
ethernet driver starts to receive packets before the IP layer is
initialized.
This pathch is originally from Stefan Nickl <Stefan.Nickl@kontron.com>
for the linuxppc2.4 three, redone for 2.6 and tested.
Signed-off-by: Rune Torgersen <runet@innovsys.com>
Rune Torgersen
System Developer
Innovative Systems LLC
1000 Innovative Drive
Mitchell, SD 57301
Ph: 605-995-6120
www.innovsys.com
[-- Attachment #2: fcc_enet_startup_crash.patch --]
[-- Type: application/octet-stream, Size: 955 bytes --]
===== arch/ppc/8260_io/fcc_enet.c 1.24 vs edited =====
--- 1.24/arch/ppc/8260_io/fcc_enet.c 2005-03-18 14:51:31 -06:00
+++ edited/arch/ppc/8260_io/fcc_enet.c 2005-04-07 14:13:31 -05:00
@@ -2158,16 +2158,6 @@
*(volatile uint *)(BCSR_ADDR + 12) &= ~BCSR3_FETHIEN2;
*(volatile uint *)(BCSR_ADDR + 12) |= BCSR3_FETH2_RST;
#endif
-
-#if defined(CONFIG_USE_MDIO) || defined(CONFIG_TQM8260)
- /* start in full duplex mode, and negotiate speed
- */
- fcc_restart (dev, 1);
-#else
- /* start in half duplex mode
- */
- fcc_restart (dev, 0);
-#endif
}
#ifdef CONFIG_USE_MDIO
@@ -2367,6 +2357,16 @@
fcc_enet_open(struct net_device *dev)
{
struct fcc_enet_private *fep = dev->priv;
+
+#if defined(CONFIG_USE_MDIO) || defined(CONFIG_TQM8260)
+ /* start in full duplex mode, and negotiate speed
+ */
+ fcc_restart (dev, 1);
+#else
+ /* start in half duplex mode
+ */
+ fcc_restart (dev, 0);
+#endif
#ifdef CONFIG_USE_MDIO
fep->sequence_done = 0;
reply other threads:[~2005-04-07 19:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCEAAC0833DD314AB0B58112AD99B93B859341@ismail.innsys.innovsys.com \
--to=runet@innovsys.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox