RE: [PATCH] RE: FCC Ethernet startup crash

["Rune Torgersen" <runet@innovsys.com>]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

Found a soulution.
Still have no idea about the cause.

The part that had to be called twice toget the ethernet to work was 

	/* Enable transmit/receive */
	fccp->fcc_gfmr |= FCC_GFMR_ENR | FCC_GFMR_ENT;

So I added that to the end of init_fcc_startup(), and kept the rest of
the patch the same as v1 (or v2)
None of the interrupts are enabled at this time, so any spurious packets
will not get reported up to IP layer anyways.

This works on my hardware. (tested with ping -f)

Signed-off-by: Rune Torgersen <runet@innovsys.com>

[-- Attachment #2: fcc_enet_startup_crash_v4.patch --]
[-- Type: application/octet-stream, Size: 1798 bytes --]

===== arch/ppc/8260_io/fcc_enet.c 1.24 vs edited =====
--- 1.24/arch/ppc/8260_io/fcc_enet.c	2005-03-18 14:51:31 -06:00
+++ edited/arch/ppc/8260_io/fcc_enet.c	2005-04-11 09:34:10 -05:00
@@ -2159,15 +2159,8 @@
 	*(volatile uint *)(BCSR_ADDR + 12) |=  BCSR3_FETH2_RST;
 #endif
 
-#if defined(CONFIG_USE_MDIO) || defined(CONFIG_TQM8260)
-	/* start in full duplex mode, and negotiate speed
-	 */
-	fcc_restart (dev, 1);
-#else
-	/* start in half duplex mode
-	 */
-	fcc_restart (dev, 0);
-#endif
+	/* Enable transmit/receive */
+	fccp->fcc_gfmr |= FCC_GFMR_ENR | FCC_GFMR_ENT;
 }
 
 #ifdef	CONFIG_USE_MDIO
@@ -2372,24 +2365,28 @@
 	fep->sequence_done = 0;
 	fep->link = 0;
 
-	if (fep->phy) {
-		fcc_restart(dev, 0);	/* always start in half-duplex */
-		mii_do_cmd(dev, fep->phy->ack_int);
-		mii_do_cmd(dev, fep->phy->config);
-		mii_do_cmd(dev, phy_cmd_config);  /* display configuration */
-		while(!fep->sequence_done)
-			schedule();
-
-		mii_do_cmd(dev, fep->phy->startup);
-		netif_start_queue(dev);
-		return 0;		/* Success */
-	}
-	return -ENODEV;		/* No PHY we understand */
+	if (!fep->phy)
+		return -ENODEV;		/* No PHY we understand */
+
+	mii_do_cmd(dev, fep->phy->ack_int);
+	mii_do_cmd(dev, fep->phy->config);
+	mii_do_cmd(dev, phy_cmd_config);  /* display configuration */
+	while(!fep->sequence_done)
+		schedule();
+
+	mii_do_cmd(dev, fep->phy->startup);
 #else
 	fep->link = 1;
-	fcc_restart(dev, 0);	/* always start in half-duplex */
-	netif_start_queue(dev);
-	return 0;					/* Always succeed */
 #endif	/* CONFIG_USE_MDIO */
+
+	netif_start_queue(dev);
+
+#if defined(CONFIG_USE_MDIO) || defined(CONFIG_TQM8260)
+	fcc_restart (dev, 1);	/* start in full duplex mode */
+#else
+	fcc_restart (dev, 0);	/* start in half duplex mode */
+#endif
+
+	return 0;		/* Always succeed */
 }