From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA88BCCF2EE for ; Mon, 19 Jan 2026 11:50:11 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4dvpfp1hzgz2xjb; Mon, 19 Jan 2026 22:50:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768821995; cv=none; b=jbusOMSDHsbeqxz22Ww4XLeopxyQGVVYqysvoS8GGcC9KyMidiFLHOu2pjIRj7bt6Z6RF5X7juG+xxauqYt7RetUto3sUXymqzj1uGSTa8dBn2luyvFaRJ3QrRkjjoeUGazA33mRLbjY9VIx23CIE115C3P1UiicJBdiPpB9ooxMbG9o5SPCu8lpCGBs04oH4h6aQhbGtvJ5Eoaj9QSNtndGwT8P3jS2eUbV7VM83RXYTN2SKKArzYDrx6pdLZlu4NWGxaVTO8wxZvsWcSZLL6zOWFV5BUO/E586IgKBXwOrhjmvTFiy52Xn3QGDSW8kS4VkpE0BqkQcKzuxJSLhQA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768821995; c=relaxed/relaxed; bh=jJFCPZlfc2d0XP2YZvhE7/lV60DrBLW++wy0oKt7axQ=; h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc: References:In-Reply-To; b=SLVkNW5nms4xqGVbLRZ21V80mm5hvHqV5a3aBbkLC2nv7G8DQMDbO8CYyd02eEqOhfHkQdZp7xXnL8cpAtSRvd6hTNaCTpb/MXgjFHutP1pMdaEa2xtwoDVBXKXbkoGxl2MvG7MDoyJtf1JV1dUjJtulJSoHkUZnh8mF0cecUzjb0PdY6dbxFf4BoBY2jOeTzM6dfP1Ix1ch3DDCinGZkvP7FQGKGge7QaT6Lz4UTc9KANsiYFQOxpm33N7FBuexacl1PPkZ0AMYUSrGa7nIskmNRg+mSf6gzVrl87YbTuBPtjNffNrm3Tj9r9NWKaZG4ELo0/T41p+GoPmRFnetcA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=l5ZSURRT; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=dakr@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=l5ZSURRT; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=dakr@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4dvp7Z3ypfz2xHW for ; Mon, 19 Jan 2026 22:26:34 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3117B41996; Mon, 19 Jan 2026 11:26:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE914C116C6; Mon, 19 Jan 2026 11:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768821991; bh=TRoYFafhv6XYbtQkSQrDP1VuW/VHQIo2+i4Os6bLwHs=; h=Date:To:From:Subject:Cc:References:In-Reply-To:From; b=l5ZSURRT9nh/iNJP+CEEkjm7D6tFTPPkk6CKCVRdP2iiQf85uUvxe3+WZYtnyIFk9 rpI5wivHag132WVnVHOYItMfj1s1t2M6bJM6MqF/VIaQUI74kAWww9I1X0uScXLGIA QuLJaY7iyJ1ghVoNbJVvO1jAeakYmazsiAtd99FuayT/yWM70YaAV9ZBM7AbmgShUw uhCBzpfV2sVtxNg1R/IxbZx6hlPkoEXnBjj4LkatT2DEIQxIT/6hBWvUWH4gySFxc3 S3qWf7aJsJ4gkrmhF0iJa0enabfTojzMWOvehsLySEGIH9rYKpCRT601kLyQtvBbyy ElAwngxihO8cg== X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 19 Jan 2026 12:26:25 +0100 Message-Id: To: "Bartosz Golaszewski" From: "Danilo Krummrich" Subject: Re: [PATCH 1/8] of: provide of_machine_get_compatible() Cc: "Rob Herring" , "Saravana Kannan" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "Christophe Leroy (CS GROUP)" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Geert Uytterhoeven" , "Magnus Damm" , "Chen-Yu Tsai" , "Jernej Skrabec" , "Samuel Holland" , , , , , , , References: <20260119-soc-of-root-v1-0-32a0fa9a78b4@oss.qualcomm.com> <20260119-soc-of-root-v1-1-32a0fa9a78b4@oss.qualcomm.com> In-Reply-To: <20260119-soc-of-root-v1-1-32a0fa9a78b4@oss.qualcomm.com> On Mon Jan 19, 2026 at 11:40 AM CET, Bartosz Golaszewski wrote: > +/** > + * of_machine_get_compatible - Get the compatible string of this machine > + * @compatible: address at which the compatible string will be stored > + * > + * Returns: > + * 0 on success, negative error number on failure. > + */ > +int of_machine_get_compatible(const char **compatible) I think the name of this function is not ideal. 'get' usually indicates tha= t a reference count will be taken, but this is not the case here. I'm also not sure about the machine prefix. If we really want this helper I= 'd suggest something along the lines of e.g. of_root_read_compatible(). > +{ > + return of_property_read_string(of_root, "compatible", compatible); > +} > +EXPORT_SYMBOL_GPL(of_machine_get_compatible);