From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA640C433E0 for ; Sun, 10 Jan 2021 12:07:44 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA9592376E for ; Sun, 10 Jan 2021 12:07:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA9592376E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DDFvx5SGlzDqNN for ; Sun, 10 Jan 2021 23:07:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=crapouillou.net (client-ip=89.234.176.197; helo=aposti.net; envelope-from=paul@crapouillou.net; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=crapouillou.net Received: from aposti.net (aposti.net [89.234.176.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DDFBv6qglzDqMk for ; Sun, 10 Jan 2021 22:35:35 +1100 (AEDT) Date: Sun, 10 Jan 2021 11:35:01 +0000 From: Paul Cercueil Subject: Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic To: Thomas Bogendoerfer Message-Id: In-Reply-To: <20210109003352.GA18102@alpha.franken.de> References: <20210108235805.GA17543@alpha.franken.de> <20210109003352.GA18102@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Sun, 10 Jan 2021 23:04:06 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: juri.lelli@redhat.com, linux-aio@kvack.org, airlied@linux.ie, nouveau@lists.freedesktop.org, bigeasy@linutronix.de, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, bsegall@google.com, jcmvbkbc@gmail.com, ray.huang@amd.com, paulus@samba.org, kraxel@redhat.com, sparclinux@vger.kernel.org, deanbo422@gmail.com, hch@lst.de, vincent.guittot@linaro.org, paulmck@kernel.org, x86@kernel.org, linux@armlinux.org.uk, linux-csky@vger.kernel.org, mingo@kernel.org, peterz@infradead.org, linux-graphics-maintainer@vmware.com, bskeggs@redhat.com, airlied@redhat.com, linux-snps-arc@lists.infradead.org, linux-mm@kvack.org, mgorman@suse.de, linux-xtensa@linux-xtensa.org, arnd@arndb.de, intel-gfx@lists.freedesktop.org, sroland@vmware.com, josef@toxicpanda.com, rostedt@goodmis.org, torvalds@linuxfoundation.org, green.hu@gmail.com, rodrigo.vivi@intel.com, dsterba@suse.com, tglx@linutronix.de, virtualization@lists.linux-foundation.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, chris@zankel.net, monstr@monstr.eu, nickhu@andestech.com, clm@fb.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, christian.koenig@amd.com, bcrl@kvack.org, spice-devel@lists.freedesktop.org, vgupta@synopsys.com, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, bristot@redhat.com, davem@davemloft.net, linux-btrfs@vger.kernel.org, viro@zeniv.linux.org.uk Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Thomas, Le sam. 9 janv. 2021 =E0 1:33, Thomas Bogendoerfer=20 a =E9crit : > On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: >> On Fri, Jan 08, 2021 at 08:20:43PM +0000, Paul Cercueil wrote: >> > Hi Thomas, >> > >> > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this=20 >> commit. >> > >> > Any idea what could be happening? >>=20 >> not yet, kernel crash log of a Malta QEMU is below. >=20 > update: >=20 > This dirty hack lets the Malta QEMU boot again: >=20 > diff --git a/mm/highmem.c b/mm/highmem.c > index c3a9ea7875ef..190cdda1149d 100644 > --- a/mm/highmem.c > +++ b/mm/highmem.c > @@ -515,7 +515,7 @@ void *__kmap_local_pfn_prot(unsigned long pfn,=20 > pgprot_t prot) > vaddr =3D __fix_to_virt(FIX_KMAP_BEGIN + idx); > BUG_ON(!pte_none(*(kmap_pte - idx))); > pteval =3D pfn_pte(pfn, prot); > - set_pte_at(&init_mm, vaddr, kmap_pte - idx, pteval); > + set_pte(kmap_pte - idx, pteval); > arch_kmap_local_post_map(vaddr, pteval); > current->kmap_ctrl.pteval[kmap_local_idx()] =3D pteval; > preempt_enable(); >=20 > set_pte_at() tries to update cache and could do an kmap_atomic()=20 > there. > Not sure, if this is allowed at this point. Yes, I can confirm that your workaround works here too. Cheers, -Paul