From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Sven Peter <sven@svenpeter.dev>
Cc: Darren Stevens <darren@stevens-zone.net>,
Arnd Bergmann <arnd@arndb.de>, Hector Martin <marcan@marcan.st>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-i2c@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
"R.T.Dickinson" <rtd2@xtra.co.nz>,
Olof Johansson <olof@lixom.net>,
mohamed.mediouni@caramail.com, Matthew Leaman <matthew@a-eon.biz>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"R.T.Dickinson" <rtd@a-eon.com>,
linux-arm-kernel@lists.infradead.org,
Stan Skowronek <stan@corellium.com>
Subject: Re: Add Apple M1 support to PASemi i2c driver
Date: Mon, 4 Oct 2021 11:22:48 +0200 [thread overview]
Message-ID: <E1746395-FC34-4096-80BA-945559F263F2@xenosoft.de> (raw)
In-Reply-To: <49890226-cf04-46ff-bc37-33d1643faea2@www.fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 2505 bytes --]
> On 3. Oct 2021, at 16:36, Sven Peter <sven@svenpeter.dev> wrote:
>
> Hi,
>
>
>> On Fri, Oct 1, 2021, at 06:47, Christian Zigotzky wrote:
>>> On 27 September 2021 at 07:39 am, Sven Peter wrote:
>>> Hi Christian,
>>>
>>> Thanks already for volunteering to test this!
>>>
>> Hello Sven,
>>
>> Damien (Hypex) has successfully tested the RC3 of kernel 5.15 with your
>> modified i2c driver on his Nemo board yesterday. [1]
>
> Thanks a lot, that's great to hear!
> If he wants to I can credit him with a Tested-by tag in the commit message,
> see e.g. https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes.
>
>
> Best,
>
>
> Sven
Hi Sven,
Unfortunately Damien has found an issue. [1]
Output of i2cdetect -l with the default RC3 of kernel 5.15 without your modifications:
2c-0 i2c Radeon i2c bit bus 0x90 I2C adapter
i2c-1 i2c Radeon i2c bit bus 0x91 I2C adapter
i2c-2 i2c Radeon i2c bit bus 0x92 I2C adapter
i2c-3 i2c Radeon i2c bit bus 0x93 I2C adapter
i2c-4 i2c Radeon i2c bit bus 0x94 I2C adapter
i2c-5 i2c Radeon i2c bit bus 0x95 I2C adapter
i2c-6 i2c Radeon i2c bit bus 0x96 I2C adapter
i2c-7 i2c Radeon i2c bit bus 0x97 I2C adapter
i2c-8 i2c PA Semi SMBus adapter at 0x800200 I2C adapter
i2c-9 i2c PA Semi SMBus adapter at 0x800240 I2C adapter
i2c-10 i2c PA Semi SMBus adapter at 0x800280 I2C adapter
Output of i2cdetect -l with your modifications:
i2c-0 i2c Radeon i2c bit bus 0x90 I2C adapter
i2c-1 i2c Radeon i2c bit bus 0x91 I2C adapter
i2c-2 i2c Radeon i2c bit bus 0x92 I2C adapter
i2c-3 i2c Radeon i2c bit bus 0x93 I2C adapter
i2c-4 i2c Radeon i2c bit bus 0x94 I2C adapter
i2c-5 i2c Radeon i2c bit bus 0x95 I2C adapter
i2c-6 i2c Radeon i2c bit bus 0x96 I2C adapter
i2c-7 i2c Radeon i2c bit bus 0x97 I2C adapter
i2c-8 i2c PA Semi SMBus adapter at 0x(____ptrval____) I2C adapter
i2c-9 i2c PA Semi SMBus adapter at 0x(____ptrval____) I2C adapter
i2c-10 i2c PA Semi SMBus adapter at 0x(____ptrval____) I2C adapter
Please check the outputs.
Thanks,
Christian
[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54165#p54165
[-- Attachment #2: Type: text/html, Size: 8612 bytes --]
next prev parent reply other threads:[~2021-10-04 22:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 14:55 Add Apple M1 support to PASemi i2c driver Christian Zigotzky
2021-09-26 20:27 ` Christian Zigotzky
2021-09-27 5:39 ` Sven Peter
2021-09-27 7:07 ` Wolfram Sang
2021-09-27 7:58 ` Michael Ellerman
2021-09-27 14:46 ` Christian Zigotzky
2021-10-08 20:19 ` Christian Zigotzky
2021-10-08 20:47 ` Olof Johansson
2021-10-09 6:10 ` Christian Zigotzky
2021-10-01 4:47 ` Christian Zigotzky
2021-10-01 5:49 ` Christian Zigotzky
2021-10-03 14:36 ` Sven Peter
2021-10-03 15:45 ` Christian Zigotzky
2021-10-04 9:22 ` Christian Zigotzky [this message]
2021-10-04 9:47 ` Christian Zigotzky
2021-10-04 9:55 ` Wolfram Sang
2021-10-04 11:20 ` Arnd Bergmann
2021-10-04 11:22 ` Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1746395-FC34-4096-80BA-945559F263F2@xenosoft.de \
--to=chzigotzky@xenosoft.de \
--cc=alyssa@rosenzweig.io \
--cc=arnd@arndb.de \
--cc=darren@stevens-zone.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marcan@marcan.st \
--cc=mark.kettenis@xs4all.nl \
--cc=matthew@a-eon.biz \
--cc=mohamed.mediouni@caramail.com \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
--cc=rtd2@xtra.co.nz \
--cc=rtd@a-eon.com \
--cc=stan@corellium.com \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).