* dtc: Remove bogus break statement
@ 2007-06-28 1:32 David Gibson
2007-07-02 13:33 ` Jon Loeliger
0 siblings, 1 reply; 2+ messages in thread
From: David Gibson @ 2007-06-28 1:32 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev, 5B
Commit 0738774fcc34b78a708a127fb4b2f193d08c94ba introduced some
incorrect indentation / bracketing in unflatten_tree(). By luck, the
extra break statement intended to be within an if block, but actually
afterwards has no semantic effect. Still, this patch gets rid of it
for cleanliness.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Index: dtc/flattree.c
===================================================================
--- dtc.orig/flattree.c 2007-06-26 15:28:34.000000000 +1000
+++ dtc/flattree.c 2007-06-26 15:28:52.000000000 +1000
@@ -779,7 +779,6 @@ static struct node *unflatten_tree(struc
if (!(flags & FTF_NOPS))
fprintf(stderr, "Warning: NOP tag found in flat tree"
" version <16\n");
- break;
/* Ignore */
break;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: dtc: Remove bogus break statement
2007-06-28 1:32 dtc: Remove bogus break statement David Gibson
@ 2007-07-02 13:33 ` Jon Loeliger
0 siblings, 0 replies; 2+ messages in thread
From: Jon Loeliger @ 2007-07-02 13:33 UTC (permalink / raw)
To: David Gibson; +Cc: linuxppc-dev, 5B
So, like, the other day David Gibson mumbled:
> Commit 0738774fcc34b78a708a127fb4b2f193d08c94ba introduced some
> incorrect indentation / bracketing in unflatten_tree(). By luck, the
> extra break statement intended to be within an if block, but actually
> afterwards has no semantic effect. Still, this patch gets rid of it
> for cleanliness.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
Thanks,
jdl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-02 13:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-28 1:32 dtc: Remove bogus break statement David Gibson
2007-07-02 13:33 ` Jon Loeliger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).