* [PATCH v2] dtc: Add install makefile target
@ 2007-06-29 14:53 Josh Boyer
2007-06-29 15:24 ` Andreas Schwab
2007-07-02 13:42 ` Jon Loeliger
0 siblings, 2 replies; 6+ messages in thread
From: Josh Boyer @ 2007-06-29 14:53 UTC (permalink / raw)
To: jdl; +Cc: linuxppc-dev, david
Add a minimal install target
Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
---
Makefile | 9 +++++++++
1 file changed, 9 insertions(+)
--- dtc.orig/Makefile
+++ dtc/Makefile
@@ -4,6 +4,10 @@ LDFLAGS = -Llibfdt
BISON = bison
+INSTALL = /usr/bin/install
+DESTDIR =
+BINDIR = /usr/bin
+
#
# Overall rules
#
@@ -113,3 +117,8 @@ endif
#
TESTS_PREFIX=tests/
include tests/Makefile.tests
+
+install: dtc ftdump
+ $(INSTALL) -d $(DESTDIR)/$(BINDIR)
+ $(INSTALL) -m 755 dtc $(DESTDIR)/$(BINDIR)
+ $(INSTALL) -m 755 ftdump $(DESTDIR)/$(BINDIR)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dtc: Add install makefile target
2007-06-29 14:53 [PATCH v2] dtc: Add install makefile target Josh Boyer
@ 2007-06-29 15:24 ` Andreas Schwab
2007-06-29 15:32 ` Josh Boyer
2007-07-02 13:42 ` Jon Loeliger
1 sibling, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2007-06-29 15:24 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, david
Josh Boyer <jwboyer@linux.vnet.ibm.com> writes:
> +install: dtc ftdump
> + $(INSTALL) -d $(DESTDIR)/$(BINDIR)
> + $(INSTALL) -m 755 dtc $(DESTDIR)/$(BINDIR)
> + $(INSTALL) -m 755 ftdump $(DESTDIR)/$(BINDIR)
Don't put a slash after $(DESTDIR). You'll end up with a doulbe slash.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dtc: Add install makefile target
2007-06-29 15:24 ` Andreas Schwab
@ 2007-06-29 15:32 ` Josh Boyer
0 siblings, 0 replies; 6+ messages in thread
From: Josh Boyer @ 2007-06-29 15:32 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linuxppc-dev, david
On Fri, 2007-06-29 at 17:24 +0200, Andreas Schwab wrote:
> Josh Boyer <jwboyer@linux.vnet.ibm.com> writes:
>
> > +install: dtc ftdump
> > + $(INSTALL) -d $(DESTDIR)/$(BINDIR)
> > + $(INSTALL) -m 755 dtc $(DESTDIR)/$(BINDIR)
> > + $(INSTALL) -m 755 ftdump $(DESTDIR)/$(BINDIR)
>
> Don't put a slash after $(DESTDIR). You'll end up with a doulbe slash.
/me bangs head on desk.
Why is it that the 9 line patches are always the most screwed up ones?
I'll fix it again. Maybe after more coffee.
josh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dtc: Add install makefile target
2007-06-29 14:53 [PATCH v2] dtc: Add install makefile target Josh Boyer
2007-06-29 15:24 ` Andreas Schwab
@ 2007-07-02 13:42 ` Jon Loeliger
2007-07-02 13:46 ` Josh Boyer
1 sibling, 1 reply; 6+ messages in thread
From: Jon Loeliger @ 2007-07-02 13:42 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, david
So, like, the other day Josh Boyer mumbled:
> Add a minimal install target
>
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Applied with the following changes --amend'ed in as well:
> +install: dtc ftdump
> + $(INSTALL) -d $(DESTDIR)/$(BINDIR)
> + $(INSTALL) -m 755 dtc $(DESTDIR)/$(BINDIR)
> + $(INSTALL) -m 755 ftdump $(DESTDIR)/$(BINDIR)
Don't put a slash after $(DESTDIR). You'll end up with a doulbe slash.
Andreas.
Thanks,
jdl
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] dtc: Add install makefile target
2007-07-02 13:42 ` Jon Loeliger
@ 2007-07-02 13:46 ` Josh Boyer
2007-07-02 14:36 ` Jon Loeliger
0 siblings, 1 reply; 6+ messages in thread
From: Josh Boyer @ 2007-07-02 13:46 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev, david
On Mon, 2007-07-02 at 08:42 -0500, Jon Loeliger wrote:
> So, like, the other day Josh Boyer mumbled:
> > Add a minimal install target
> >
> > Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
>
> Applied with the following changes --amend'ed in as well:
Great. Thanks Jon, saves me from having to send out yet another patch.
josh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dtc: Add install makefile target
2007-07-02 13:46 ` Josh Boyer
@ 2007-07-02 14:36 ` Jon Loeliger
0 siblings, 0 replies; 6+ messages in thread
From: Jon Loeliger @ 2007-07-02 14:36 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, david
So, like, the other day Josh Boyer mumbled:
> > Applied with the following changes --amend'ed in as well:
>
> Great. Thanks Jon, saves me from having to send out yet another patch.
No problem. --amend is spiffy. And besides, we
really should avoid those "doulbe slash" [sic] issues!
jdl
PS -- Thankfully, we avoided any Angryflower Incidents! :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-07-02 14:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-29 14:53 [PATCH v2] dtc: Add install makefile target Josh Boyer
2007-06-29 15:24 ` Andreas Schwab
2007-06-29 15:32 ` Josh Boyer
2007-07-02 13:42 ` Jon Loeliger
2007-07-02 13:46 ` Josh Boyer
2007-07-02 14:36 ` Jon Loeliger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).