From: Jon Loeliger <jdl@jdl.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: libfdt: Consistently use big-endian property data in testcases
Date: Mon, 17 Sep 2007 14:24:25 -0500 [thread overview]
Message-ID: <E1IXMCn-0002md-8u@jdl.com> (raw)
In-Reply-To: Your message of "Mon, 17 Sep 2007 15:42:36 +1000." <20070917054236.GA9303@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> Flat device trees always have integers in their structure stored as
> big-endian. From this point of view, property values are
> bags-of-bytes and any endianness is up to users of the device tree to
> determine.
>
> The libfdt testcases which use properties with integer values,
> currently use native endian format for the architecture on which the
> testcases are run. This works ok for now, since both the creation and
> checking of the example device trees happen in the same endianness.
>
> This will become a problem, however, for tests of dtc which we want to
> add in the nearish future. dtc always uses big-endian format for
> 'cell' format data in properties; as it needs to in order to produce
> powerpc-usable device trees when hosted on a little-endian
> architecture.
>
> This patch, therefore, changes the libfdt testsuite to use big-endian
> format always for integer format data, in order to interoperate sanely
> with future dtc testcases. This also means that the example trees
> created by the testsuite should now be byte-for-byte identical
> regardless of dtc and libfdt's host platform, which is arguably an
> advantage.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
jdl
prev parent reply other threads:[~2007-09-17 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 5:42 libfdt: Consistently use big-endian property data in testcases David Gibson
2007-09-17 19:24 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1IXMCn-0002md-8u@jdl.com \
--to=jdl@jdl.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).