linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@jdl.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: dtc: Improve support for string escapes
Date: Tue, 16 Oct 2007 08:14:20 -0500	[thread overview]
Message-ID: <E1IhmFY-0002wD-Iv@jdl.com> (raw)
In-Reply-To: Your message of "Tue, 16 Oct 2007 16:42:02 +1000." <20071016064202.GC9052@localhost.localdomain>

So, like, the other day David Gibson mumbled:
> dtc supports the use of C-style escapes (\n, \t and so forth) in
> string property definitions via the data_copy_escape_string()
> function.  However, while it supports the most common escape
> characters, it doesn't support the full set that C does, which is a
> potential gotcha.
> 
> Worse, a bug in the lexer means that while data_copy_escape_string()
> can handle the \" escape, a string with such an escape won't lex
> correctly.
> 
> This patch fixes both problems, extending data_copy_escape_string() to
> support the missing escapes, and fixing the regex for strings in the
> lexer to handle internal escaped quotes.
> 
> This also adds a testcase for string escape functionality.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Excellent.  Thanks.

> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ dtc/tests/string_escapes.c	2007-10-16 16:34:20.000000000 +1000
> @@ -0,0 +1,42 @@
> +/*
> + * libfdt - Flat Device Tree manipulation
> + *	Testcase for strinc escapes in dtc

Applied, modulo fixing that typo.

jdl

      reply	other threads:[~2007-10-16 13:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-16  6:42 dtc: Improve support for string escapes David Gibson
2007-10-16 13:14 ` Jon Loeliger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IhmFY-0002wD-Iv@jdl.com \
    --to=jdl@jdl.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).