From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: David Gibson Subject: Re: libfdt: Abolish fdt_offset_ptr_typed() In-Reply-To: Your message of "Mon, 19 Nov 2007 17:26:22 +1100." <20071119062622.GL20794@localhost.localdomain> References: <20071119062622.GL20794@localhost.localdomain> Date: Tue, 20 Nov 2007 09:06:11 -0600 From: Jon Loeliger Message-Id: Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , So, like, the other day David Gibson mumbled: > The fdt_offset_ptr_typed() macro seemed like a good idea at the time. > However, it's not actually used all that often, it can silently throw > away const qualifications and it uses a gcc extension (typeof) which > I'd prefer to avoid for portability. > > Therefore, this patch gets rid of it (and the fdt_offset_ptr_typed_w() > variant which was never used at all). It also makes a few variables > const in testcases, which always should have been const, but weren't > caught before because of the aforementioned silent discards. > > Signed-off-by: David Gibson Applied. jdl