From: Kumar Gala <galak@kernel.crashing.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linuxppc-dev Development <linuxppc-dev@ozlabs.org>
Subject: removing pcibios_fixup_bus
Date: Wed, 13 May 2009 10:17:25 -0500 [thread overview]
Message-ID: <E3137750-3D9B-40FF-AB03-7F0999C97C4A@kernel.crashing.org> (raw)
Ben,
We have:
/* Platform specific bus fixups. This is currently only used
* by fsl_pci and I'm hoping to get rid of it at some point
*/
if (ppc_md.pcibios_fixup_bus)
ppc_md.pcibios_fixup_bus(bus);
I can remove this but would need to replace it with:
if (bus->self != NULL) {
pci_read_bridge_bases(bus);
if (ppc_md.pcibios_fixup_bridge_resources)
ppc_md.pcibios_fixup_bridge_resources(bus);
}
This is only moving the issue, but its a bit cleaner as the fixup I'm
doing is because when we read the BARs on the virtual P2P bridge on
our PCIe PHBs we get bogus values back.
Thoughts?
- k
reply other threads:[~2009-05-13 15:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3137750-3D9B-40FF-AB03-7F0999C97C4A@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox