From: Kumar Gala <galak@kernel.crashing.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: David Howells <dhowells@redhat.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: fix build when CONFIG_BOOKE_WDT is enabled
Date: Thu, 19 Apr 2012 15:15:25 -0500 [thread overview]
Message-ID: <E58B01B5-BE5C-4857-A31C-58CBB0AD5937@kernel.crashing.org> (raw)
In-Reply-To: <4c2709df9123c32681503972be3707026c9dab74.1334816894.git.baruch@tkos.co.il>
On Apr 19, 2012, at 1:32 AM, Baruch Siach wrote:
> Commit ae3a197e (Disintegrate asm/system.h for PowerPC) broke build of
> assembly files when CONFIG_BOOKE_WDT is enabled as follows:
>=20
> AS arch/powerpc/lib/string.o
> /home/baruch/git/stable/arch/powerpc/include/asm/reg_booke.h: =
Assembler messages:
> /home/baruch/git/stable/arch/powerpc/include/asm/reg_booke.h:19: =
Error: Unrecognized opcode: `extern'
> /home/baruch/git/stable/arch/powerpc/include/asm/reg_booke.h:20: =
Error: Unrecognized opcode: `extern'
>=20
> Since setup_32.c is the only user of the booke_wdt configuration =
variables, move
> the declarations there.
>=20
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> arch/powerpc/include/asm/reg_booke.h | 5 -----
> arch/powerpc/kernel/setup_32.c | 5 +++++
> 2 files changed, 5 insertions(+), 5 deletions(-)
applied to merge, minor moving of the externs to be in same ifdef in =
setup_32.c
- k=
prev parent reply other threads:[~2012-04-19 20:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 6:32 [PATCH] powerpc: fix build when CONFIG_BOOKE_WDT is enabled Baruch Siach
2012-04-19 20:15 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E58B01B5-BE5C-4857-A31C-58CBB0AD5937@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=baruch@tkos.co.il \
--cc=dhowells@redhat.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).