From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 07662B7DEA for ; Fri, 19 Feb 2010 09:01:20 +1100 (EST) Subject: Re: [PATCH] powerpc/85xx: Convert socrates_fpga_pic_lock to raw_spinlock Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <20100218134512.GB5331@oksana.dev.rtsoft.ru> Date: Thu, 18 Feb 2010 16:01:09 -0600 Message-Id: References: <20100218121904.620984825@linutronix.de> <20100218134512.GB5331@oksana.dev.rtsoft.ru> To: avorontsov@ru.mvista.com Cc: linuxppc-dev@ozlabs.org, Thomas Gleixner List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Feb 18, 2010, at 7:45 AM, Anton Vorontsov wrote: > Interrupt controllers' hooks are executed in the atomic context, so > they are not permitted to sleep (with RT kernels non-raw spinlocks are > sleepable). So, socrates_fpga_pic_lock has to be a real = (non-sleepable) > spinlock. >=20 > Signed-off-by: Anton Vorontsov > --- >=20 > On Thu, Feb 18, 2010 at 12:22:18PM -0000, Thomas Gleixner wrote: >> Ben, >>=20 >> the following patch series is from preempt-rt. It converts the locks >> which need to be real spinlocks in -rt to raw_spinlocks. >>=20 >> There is no behaviourial change for !RT kernels because spinlocks and >> raw_spinlocks are the same on !RT. So for mainline this is a pure >> annotation while having it in mainline takes the burden of keeping up >> with the code changes from the RT patch set. >>=20 >> Please consider to merge into .34. >=20 > Oh, and I guess the same for the socrates fpga pic... >=20 > arch/powerpc/platforms/85xx/socrates_fpga_pic.c | 34 = +++++++++++----------- > 1 files changed, 17 insertions(+), 17 deletions(-) applied to next - k=