From: Athira Rajeev <atrajeev@linux.ibm.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Kees Cook <kees@kernel.org>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
Yury Norov <ynorov@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/perf: Use strstarts() to simplify is_thread_imc_pmu()
Date: Fri, 24 Jul 2026 09:21:56 +0530 [thread overview]
Message-ID: <EB483C96-97AD-4F3E-A513-141D6AD4186A@linux.ibm.com> (raw)
In-Reply-To: <20260704121353.201583-3-thorsten.blum@linux.dev>
> On 4 Jul 2026, at 5:43 PM, Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Replace the open-coded implementation with strstarts() to simplify
> is_thread_imc_pmu().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> arch/powerpc/perf/imc-pmu.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/perf/imc-pmu.c b/arch/powerpc/perf/imc-pmu.c
> index e3822f36c419..1d2db6d3e226 100644
> --- a/arch/powerpc/perf/imc-pmu.c
> +++ b/arch/powerpc/perf/imc-pmu.c
> @@ -1023,10 +1023,7 @@ static int thread_imc_event_init(struct perf_event *event)
>
> static bool is_thread_imc_pmu(struct perf_event *event)
> {
> - if (!strncmp(event->pmu->name, "thread_imc", strlen("thread_imc")))
> - return true;
> -
> - return false;
> + return strstarts(event->pmu->name, "thread_imc");
> }
>
Reviewed-by: Athira Rajeev <atrajeev@linux.ibm.com>
Thanks
Athira
> static __be64 *get_event_base_addr(struct perf_event *event)
>
>
prev parent reply other threads:[~2026-07-24 3:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 12:13 [PATCH] powerpc/perf: Use strstarts() to simplify is_thread_imc_pmu() Thorsten Blum
2026-07-24 3:51 ` Athira Rajeev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EB483C96-97AD-4F3E-A513-141D6AD4186A@linux.ibm.com \
--to=atrajeev@linux.ibm.com \
--cc=chleroy@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sshegde@linux.ibm.com \
--cc=thorsten.blum@linux.dev \
--cc=ynorov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox