linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "irogers@google.com" <irogers@google.com>,
	"maddy@linux.ibm.com" <maddy@linux.ibm.com>,
	"kjain@linux.ibm.com" <kjain@linux.ibm.com>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"disgoel@linux.vnet.ibm.com" <disgoel@linux.vnet.ibm.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh
Date: Thu, 12 Oct 2023 21:17:28 +0530	[thread overview]
Message-ID: <F265857D-0D37-4878-908C-D20732F212F9@linux.vnet.ibm.com> (raw)
In-Reply-To: <5d79ca77e4ca4f6c895e26384655563f@AcuMS.aculab.com>



> On 05-Oct-2023, at 9:15 PM, David Laight <David.Laight@ACULAB.COM> wrote:
> 
> From: David Laight
>> Sent: 05 October 2023 11:16
> ...
>>> - cs_etm_path=$(find  /sys/bus/event_source/devices/cs_etm/ -name cpu* -print -quit)
>>> + cs_etm_path=$(find  /sys/bus/event_source/devices/cs_etm/ -name 'cpu*' -print -quit)
>> 
>> Isn't the intention to get the shell to expand "cpu* ?
>> So quoting it completely breaks the script.
> 
> Complete brain-fade :-(

Hi David,

Yeah, quoting it also will expand

Thanks
Athira
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
> 


  reply	other threads:[~2023-10-12 15:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29  4:11 [PATCH 0/3] Fix for shellcheck issues with latest scripts in tests/shell Athira Rajeev
2023-09-29  4:11 ` [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh Athira Rajeev
2023-10-05  5:02   ` Namhyung Kim
2023-10-05  8:19     ` James Clark
2023-10-05  9:36     ` Suzuki K Poulose
2023-10-12 15:56       ` Athira Rajeev
2023-10-12 16:07         ` Suzuki K Poulose
2023-10-12 16:20           ` Athira Rajeev
2023-10-05  8:20   ` James Clark
2023-10-05  8:54     ` Athira Rajeev
2023-11-06 21:44       ` Arnaldo Carvalho de Melo
2023-11-07  6:38         ` Athira Rajeev
2023-11-08 20:04           ` Arnaldo Carvalho de Melo
2023-10-05 10:15   ` David Laight
2023-10-05 15:45     ` David Laight
2023-10-12 15:47       ` Athira Rajeev [this message]
2023-09-29  4:11 ` [PATCH 2/3] tools/perf/tests Ignore the shellcheck SC2046 warning in lock_contentio Athira Rajeev
2023-09-29  4:11 ` [PATCH 3/3] tools/perf/tests: Fix shellcheck warning in record_sideband.sh test Athira Rajeev
2023-10-05  5:04   ` Namhyung Kim
2023-10-05  8:55     ` Athira Rajeev
2023-10-03  7:47 ` [PATCH 0/3] Fix for shellcheck issues with latest scripts in tests/shell kajoljain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F265857D-0D37-4878-908C-D20732F212F9@linux.vnet.ibm.com \
    --to=atrajeev@linux.vnet.ibm.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=disgoel@linux.vnet.ibm.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kjain@linux.ibm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).