linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Marc Zyngier <maz@kernel.org>
Cc: apatel@ventanamicro.com, Rob Herring <robh@kernel.org>,
	Darren Stevens <darren@stevens-zone.net>,
	"R.T.Dickinson" <rtd2@xtra.co.nz>,
	DTML <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	mad skateman <madskateman@gmail.com>,
	Matthew Leaman <matthew@a-eon.biz>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Christian Zigotzky <info@xenosoft.de>
Subject: Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29
Date: Fri, 5 Jul 2024 08:59:10 +0200	[thread overview]
Message-ID: <F30D5471-B68C-442B-A34C-6EA0C8232006@xenosoft.de> (raw)
In-Reply-To: <ccf14173-9818-44ef-8610-db2900c67ae8@xenosoft.de>

[snip]

My earlier request for valuable debug information still stands. But
while you're at it, can you please give the following hack a go?

   M.

--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -282,8 +282,10 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)
               oldimap = imap;
             imap = of_irq_parse_imap_parent(oldimap, imaplen, out_irq);
-            if (!imap)
-                goto fail;
+            if (!imap) {
+                match = 0;
+                break;
+            }
               match &= of_device_is_available(out_irq->np);
             if (match)

This may not be the final workaround even if it solves your boot
problem, but will at least give us a hint at what is going wrong.

I have the fuzzy feeling that we may be able to lob this broken system
as part of the of_irq_imap_abusers[] array, which would solve things
pretty "neatly".

   M.

- - - -

We tested this patch yesterday and it solves the boot problem.

Thanks

- - - -

I am sorry our tester was wrong and has reported, that this kernel doesn’t boot.

Link: https://forum.hyperion-entertainment.com/viewtopic.php?p=58627#p58627

Sorry

      parent reply	other threads:[~2024-07-05  7:00 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-30 10:21 [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29 Christian Zigotzky
2024-07-02 15:19 ` Marc Zyngier
2024-07-02 17:55   ` Christian Zigotzky
2024-07-02 19:49     ` Marc Zyngier
2024-07-03  3:11       ` Christian Zigotzky
2024-07-03  6:40         ` Marc Zyngier
2024-07-03 10:26           ` Christian Zigotzky
2024-07-03 10:41             ` Marc Zyngier
2024-07-03 16:23               ` Christian Zigotzky
2024-07-02 16:54 ` Marc Zyngier
2024-07-02 20:48   ` Rob Herring
2024-07-02 21:42     ` Marc Zyngier
2024-07-03 11:30     ` Michael Ellerman
2024-07-03 12:09       ` Marc Zyngier
2024-07-03  3:27   ` Christian Zigotzky
2024-07-03  6:41     ` Marc Zyngier
2024-07-04  4:10   ` Christian Zigotzky
2024-07-04  8:28     ` Marc Zyngier
2024-07-04 18:54       ` Christian Zigotzky
2024-07-05  7:05         ` Christian Zigotzky
2024-07-05  8:05           ` Christian Zigotzky
2024-07-05 13:01             ` Marc Zyngier
2024-07-05 13:30               ` Trevor Dickinson
2024-07-09  3:46               ` Damien Stewart
2024-07-09 12:48                 ` Michael Ellerman
2024-07-04 11:53     ` Michael Ellerman
2024-07-04 18:27       ` Christian Zigotzky
2024-07-04 18:59         ` Christian Zigotzky
2024-07-05  1:19           ` Michael Ellerman
2024-07-05 20:45             ` Segher Boessenkool
2024-07-06  3:51             ` Christian Zigotzky
2024-07-06  4:15             ` Christian Zigotzky
2024-07-06 15:54               ` Christian Zigotzky
2024-07-10  3:53                 ` Christian Zigotzky
2024-07-10 15:05                   ` Rob Herring
2024-07-10 15:53                     ` Christian Zigotzky
2024-07-06  4:08         ` Christian Zigotzky
2024-07-05  6:59     ` Christian Zigotzky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F30D5471-B68C-442B-A34C-6EA0C8232006@xenosoft.de \
    --to=chzigotzky@xenosoft.de \
    --cc=apatel@ventanamicro.com \
    --cc=darren@stevens-zone.net \
    --cc=devicetree@vger.kernel.org \
    --cc=info@xenosoft.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=madskateman@gmail.com \
    --cc=matthew@a-eon.biz \
    --cc=maz@kernel.org \
    --cc=robh@kernel.org \
    --cc=rtd2@xtra.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).