From: Rohan McLure <rmclure@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"npiggin@gmail.com" <npiggin@gmail.com>
Subject: Re: [PATCH v2 01/14] powerpc: Adopt SYSCALL_DEFINE for arch-specific syscall handlers
Date: Tue, 9 Aug 2022 10:15:29 +1000 [thread overview]
Message-ID: <F42133C5-EB83-499B-9D0F-FB974669EDE9@linux.ibm.com> (raw)
In-Reply-To: <83ed398f-ce1b-029f-2788-a4e74af5ffa5@csgroup.eu>
> Well, of course we need the patch build, so SYSCALL_DEFINE and
> COMPAT_SYSCALL_DEFINE have to go with the name changes, that's obvious.
>
> My comment was more related to changes like the renaming of
> ppc64_personality() to do_ppc64_personality() and the creation of
> sys_ppc64_personality() and compat_....
> That could be a patch by itself.
>
> Also patch 4 could go up front in order to avoid renaming a function you
> are removing in a follow-up patch.
>
> So as a summary, do all preparation up front of patch 1, in order to
> keep it as minimal.
Thanks. I’ll split up this commit accordingly.
prev parent reply other threads:[~2022-08-09 0:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 6:24 [PATCH v2 01/14] powerpc: Adopt SYSCALL_DEFINE for arch-specific syscall handlers Rohan McLure
2022-08-05 16:50 ` Christophe Leroy
2022-08-08 6:04 ` Rohan McLure
2022-08-08 9:37 ` Christophe Leroy
2022-08-09 0:15 ` Rohan McLure [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F42133C5-EB83-499B-9D0F-FB974669EDE9@linux.ibm.com \
--to=rmclure@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).