From: Segher Boessenkool <segher@kernel.crashing.org>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc: warning: allocated section `.data_nosave' not in segment
Date: Tue, 29 Sep 2009 22:40:13 +0200 [thread overview]
Message-ID: <F5F6DA96-29BC-49D3-A5C6-BBAEFFC7E885@kernel.crashing.org> (raw)
In-Reply-To: <20090929120006.78affe3f@lappy.seanm.ca>
> We need to align before the output section. Having the align inside
> the output section causes the linker to put some filler in there,
> which makes it a non-empty section, but this section isn't assigned to
> a segment so you get a warning from the linker.
>
> Signed-off-by: Sean MacLennan <smaclennan@pikatech.com>
> ---
> diff --git a/arch/powerpc/kernel/vmlinux.lds.S
> b/arch/powerpc/kernel/vmlinux.lds.S index f564293..e853763 100644
> --- a/arch/powerpc/kernel/vmlinux.lds.S
> +++ b/arch/powerpc/kernel/vmlinux.lds.S
> @@ -236,6 +236,7 @@ SECTIONS
> READ_MOSTLY_DATA(L1_CACHE_BYTES)
> }
>
> + . = ALIGN(PAGE_SIZE);
> .data_nosave : AT(ADDR(.data_nosave) - LOAD_OFFSET) {
> NOSAVE_DATA
> }
Acked-by: Segher Boessenkool <segher@kernel.crashing.org>
The patch is good and fixes a real problem. But, I still don't see how
it caused the "warning: allocated section `.data_nosave' not in
segment",
it would be good if we can find out.
Segher
prev parent reply other threads:[~2009-09-29 20:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 16:00 [PATCH] powerpc: warning: allocated section `.data_nosave' not in segment Sean MacLennan
2009-09-29 20:40 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5F6DA96-29BC-49D3-A5C6-BBAEFFC7E885@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=smaclennan@pikatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox