From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 08E15DE8D4 for ; Wed, 16 Apr 2008 01:29:42 +1000 (EST) Message-Id: From: Kumar Gala To: Robert Schwebel In-Reply-To: <20080415152638.GW13814@pengutronix.de> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Mime-Version: 1.0 (Apple Message framework v919.2) Subject: Re: fec_mpc5200: reset FEC on error Date: Tue, 15 Apr 2008 10:29:26 -0500 References: <20080415152638.GW13814@pengutronix.de> Cc: linuxppc-dev@ozlabs.org, Domen Puncer List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Apr 15, 2008, at 10:26 AM, Robert Schwebel wrote: > From: Sascha Hauer > > The error handling for the mpc5200 fec interrupt is broken. The > intended > behaviour is like this: > > * If one of FEC_IEVENT_RFIFO_ERROR and FEC_IEVENT_XFIFO_ERROR happens, > the datasheet says (MPC5200B User's Guide R1.2, p. 14-13): "When this > occurs, software must ensure both the FIFO Controller and BestComm > are > soft-reset". > > * On any other error (non-TFINT) interrupt, just issue a debug > message. > > Signed-off-by: Sascha Hauer > > --- > drivers/net/fec_mpc52xx.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > You really need to also copy netdev and patches to drivers/net. - k