Re: [PATCH 3/3] Add MPC8349E MDS device tree source file to arch/powerpc/boot/dts

[Kumar Gala <galak@kernel.crashing.org>]

On Aug 23, 2006, at 8:39 PM, Kim Phillips wrote:

> Add MPC8349E MDS device tree source file to arch/powerpc/boot/dts
>
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
>
>  arch/powerpc/boot/dts/mpc8349emds.dts |  327 ++++++++++++++++++++++ 
> +++++++++++
>  1 files changed, 327 insertions(+), 0 deletions(-)

Can we rename the defconfig to match the dts, mpc834x_sys was a bad  
choice but what was I to do.  Things seem to have stabilized on MDS  
so we should go with that.

> +
> +		/* IPIC
> +		 * interrupts cell = <intr #, sense>
> +		 * sense == 8: Level, low assertion
> +		 * sense == 2: Edge, high-to-low change
> +		 */

Would be good to add a comment that we match IORESOURCE_IRQ_* defn.

> +		pic@700 {
> +			linux,phandle = <700>;
> +			interrupt-controller;
> +			#address-cells = <0>;
> +			#interrupt-cells = <2>;
> +			reg = <700 100>;
> +			built-in;
> +			device_type = "ipic";
> +		};
> +	};
> +};
> -- 
> 2006_06_07.01.gittree_pull-dirty