From: "Stephan Linke" <Stephan.Linke@epygi.de>
To: <joakim.tjernlund@lumentis.se>
Cc: "Linuxppc-Embedded" <linuxppc-embedded@lists.linuxppc.org>
Subject: RE: [PATCH] arch/ppc/8xx_io/enet.c, version 3
Date: Tue, 4 Feb 2003 10:50:43 +0100 [thread overview]
Message-ID: <FCEAKDJJAPHPLJFINDAJGEGHCNAA.Stephan.Linke@epygi.de> (raw)
In-Reply-To: <IGEFJKJNHJDCBKALBJLLCEOFFJAA.joakim.tjernlund@lumentis.se>
Hi,
I am on an 862. Anyway I can't find another definition of dma_cache_inv() but the NO OP in asm-ppc/io.h. Could you give me e hint
where it is defined in your kernel?
Thanks, Stephan
> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernlund@lumentis.se]
> Sent: Montag, 3. Februar 2003 18:23
> To: Stephan Linke
> Subject: RE: [PATCH] arch/ppc/8xx_io/enet.c, version 3
>
>
> > Hi Jocke,
> >
> > in your latest patch you are using dma_cache_inv() instead of invalidate_dcache_range().
> > The only dma_cache_inv() I can find is in include/asm-ppc/io.h. and it's a "do{}while(0)".
> > Are you shure that this was your intention? It seames to me like you could remove that call as well.
>
> I guess you are on 8260? On 8260 there is no need for invalidate_dcache_range() since
> it's the CPM is cache coherent. On 8xx it is not cache coherent. I switched
> to dma_cache_inv() because it's a no op on 8260 and a invalidate_dcache_range() on 8xx so
> it would be easy to adapt the patch to both CPU's.
>
> Jocke
>
>
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next parent reply other threads:[~2003-02-04 9:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <IGEFJKJNHJDCBKALBJLLCEOFFJAA.joakim.tjernlund@lumentis.se>
2003-02-04 9:50 ` Stephan Linke [this message]
2003-02-04 9:58 ` [PATCH] arch/ppc/8xx_io/enet.c, version 3 Joakim Tjernlund
2003-02-10 11:10 ` Pantelis Antoniou
2003-02-10 14:29 ` Joakim Tjernlund
2003-02-10 14:51 ` Pantelis Antoniou
2003-02-10 15:28 ` Joakim Tjernlund
2003-02-10 15:28 ` Pantelis Antoniou
2003-02-10 16:16 ` Joakim Tjernlund
2003-02-12 8:22 ` Pantelis Antoniou
2003-02-10 11:57 ` Steven Scholz
2003-02-10 12:28 ` Joakim Tjernlund
2003-02-10 14:35 ` Joakim Tjernlund
[not found] <FCEAKDJJAPHPLJFINDAJGEGICNAA.Stephan.Linke@epygi.de>
2003-02-04 10:06 ` Stephan Linke
2002-10-24 15:46 [PATCH] arch/ppc/8xx_io/enet.c, version 2 Joakim Tjernlund
2003-01-28 11:54 ` [PATCH] arch/ppc/8xx_io/enet.c, version 3 Joakim Tjernlund
2003-02-03 10:21 ` Joakim Tjernlund
2003-02-03 12:28 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FCEAKDJJAPHPLJFINDAJGEGHCNAA.Stephan.Linke@epygi.de \
--to=stephan.linke@epygi.de \
--cc=joakim.tjernlund@lumentis.se \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).