FW: 860 ATM - channel deactivation

FW: 860 ATM - channel deactivation

[Stephan Linke]

Hi,

I had a look at the sources of mpc860sar. In mpc860sar.c there is the
mpc860sar_undo_activate_channel() function that deactivates a channel (ATM
VCC) and releases the resources.
I'm curious about the fact that the deactivation of the channel by calling
mpc860sar_del_address_mapping() is performed after all the ressources where
released. Shouldn't it all be done exactly the opposite way arround?
In case the order is wrong no one will notice it as long as there's no
traffic arriving while this function is running. And I didn't had any
trouble so far too. But I'm shure it is wrong.

Could anyone check this? (I hope I'm in the right mailing list. :))

Thanks, Stephan


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

RE: 860 ATM - channel deactivation

[Fabien Clément]

This function is meant for resources freeing if channel activation fails
(see mpc860sar_open)
there is no traffic on the VCC when it's called


-----Original Message-----
From: owner-linuxppc-embedded@lists.linuxppc.org
[mailto:owner-linuxppc-embedded@lists.linuxppc.org]On Behalf Of Stephan
Linke
Sent: Monday, September 09, 2002 4:39 PM
To: Linuxppc-Embedded
Subject: FW: 860 ATM - channel deactivation



Hi,

I had a look at the sources of mpc860sar. In mpc860sar.c there is the
mpc860sar_undo_activate_channel() function that deactivates a channel (ATM
VCC) and releases the resources.
I'm curious about the fact that the deactivation of the channel by calling
mpc860sar_del_address_mapping() is performed after all the ressources where
released. Shouldn't it all be done exactly the opposite way arround?
In case the order is wrong no one will notice it as long as there's no
traffic arriving while this function is running. And I didn't had any
trouble so far too. But I'm shure it is wrong.

Could anyone check this? (I hope I'm in the right mailing list. :))

Thanks, Stephan


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: FW: 860 ATM - channel deactivation

[Alex Zeffertt]

On Mon, 9 Sep 2002, Stephan Linke wrote:


Thanks, Stephan, for pointing this out.  I think you're right.  I've also
noticed that mpc860sar_undo_activate_channel() is not disabling
receptions in the CPM - which might be necessary if mpc860sar_activate_channel()
successfully set up rx but failed on setting up tx.

I will change mpc860sar_undo_activate_channel() so that the 1st thing it
does is:

	if(chan->initialised) /* rx enabled in CPM */
		mpc860sar_rx_channel(chan->dev, CPM_CHAN_DISABLE, chan);

and the 2nd thing it does is to delete the address mapping.

I'll get round to putting this on sourceforge CVS
(CVSROOT=yourname@cvs.mpc860sar.sourceforge.net:/cvsroot/mpc860sar)
sometime today.  I'll write to you when it's done.

Alex

>
> Hi,
>
> I had a look at the sources of mpc860sar. In mpc860sar.c there is the
> mpc860sar_undo_activate_channel() function that deactivates a channel (ATM
> VCC) and releases the resources.
> I'm curious about the fact that the deactivation of the channel by calling
> mpc860sar_del_address_mapping() is performed after all the ressources where
> released. Shouldn't it all be done exactly the opposite way arround?
> In case the order is wrong no one will notice it as long as there's no
> traffic arriving while this function is running. And I didn't had any
> trouble so far too. But I'm shure it is wrong.
>
> Could anyone check this? (I hope I'm in the right mailing list. :))
>
> Thanks, Stephan
>
>
>


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/