From: Kumar Gala <galak@kernel.crashing.org>
To: Timur Tabi <timur.tabi@gmail.com>
Cc: Xulei <B33228@freescale.com>,
linux-i2c@vger.kernel.org, Ben Dooks <ben-i2c@fluff.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] I2C: Add support for 64bit system.
Date: Tue, 15 Mar 2011 11:00:03 -0500 [thread overview]
Message-ID: <FCEF0E17-0110-457C-A449-782FC01B37C3@kernel.crashing.org> (raw)
In-Reply-To: <AANLkTim0_ttjDPJvx71B-=Ze5dRTrKXfpavx7gxvYr5p@mail.gmail.com>
On Mar 15, 2011, at 10:56 AM, Timur Tabi wrote:
> On Tue, Mar 15, 2011 at 10:44 AM, Kumar Gala =
<galak@kernel.crashing.org> wrote:
>>=20
>> On Dec 20, 2010, at 8:59 AM, Ben Dooks wrote:
>>=20
>>> On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote:
>>>> Currently I2C_MPC supports 32bit system only, then this
>>>> modification makes it support 32bit and 64bit system both.
>>>>=20
>>>> Signed-off-by: Xulei <B33228@freescale.com>
>>>=20
>>> This been build or run tested?
>>=20
>> Yes, Any issues with me applying this via the powerpc.git tree?
>=20
> I'm concerned about the fact that we have to have two defines to
> declare code that is 32-bit and 64-bit clean. Technically speaking,
> all drivers should work in both environments. It seems silly to have
> "PPC32 || PPC64" for everything. Isn't there a generic "PPC" config
> option that covers this?
There is, I'll post a new patch that uses it.
- k=
prev parent reply other threads:[~2011-03-15 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 7:37 [PATCH] I2C: Add support for 64bit system Xulei
2010-12-20 14:59 ` Ben Dooks
2010-12-21 7:32 ` xulei
2011-03-15 15:44 ` Kumar Gala
2011-03-15 15:56 ` Timur Tabi
2011-03-15 16:00 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FCEF0E17-0110-457C-A449-782FC01B37C3@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=B33228@freescale.com \
--cc=ben-i2c@fluff.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur.tabi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).