From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 03D89B6FE1 for ; Wed, 16 Mar 2011 03:00:16 +1100 (EST) Subject: Re: [PATCH] I2C: Add support for 64bit system. Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: Date: Tue, 15 Mar 2011 11:00:03 -0500 Message-Id: References: <1292830654-7056-1-git-send-email-B33228@freescale.com> <20101220145954.GA1126@trinity.fluff.org> To: Timur Tabi Cc: Xulei , linux-i2c@vger.kernel.org, Ben Dooks , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mar 15, 2011, at 10:56 AM, Timur Tabi wrote: > On Tue, Mar 15, 2011 at 10:44 AM, Kumar Gala = wrote: >>=20 >> On Dec 20, 2010, at 8:59 AM, Ben Dooks wrote: >>=20 >>> On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote: >>>> Currently I2C_MPC supports 32bit system only, then this >>>> modification makes it support 32bit and 64bit system both. >>>>=20 >>>> Signed-off-by: Xulei >>>=20 >>> This been build or run tested? >>=20 >> Yes, Any issues with me applying this via the powerpc.git tree? >=20 > I'm concerned about the fact that we have to have two defines to > declare code that is 32-bit and 64-bit clean. Technically speaking, > all drivers should work in both environments. It seems silly to have > "PPC32 || PPC64" for everything. Isn't there a generic "PPC" config > option that covers this? There is, I'll post a new patch that uses it. - k=