From: Kumar Gala <galak@kernel.crashing.org>
To: Julia Lawall <julia@diku.dk>
Cc: kernel-janitors@vger.kernel.org, paulus@samba.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/3] arch/powerpc: Add kmalloc NULL tests
Date: Thu, 6 Aug 2009 21:26:59 -0500 [thread overview]
Message-ID: <FD045DD8-3932-4BA0-9AB9-C2405F601C45@kernel.crashing.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0908062203380.19100@ask.diku.dk>
On Aug 6, 2009, at 3:04 PM, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Check that the result of kmalloc/kzalloc is not NULL before
> dereferencing it.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression *x;
> identifier f;
> constant char *C;
> @@
>
> x = \(kmalloc\|kcalloc\|kzalloc\)(...);
> ... when != x == NULL
> when != x != NULL
> when != (x || ...)
> (
> kfree(x)
> |
> f(...,C,...,x,...)
> |
> *f(...,x,...)
> |
> *x->f
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> arch/powerpc/sysdev/fsl_rio.c | 18 ++++++++++++++----
> 1 files changed, 14 insertions(+), 4 deletions(-)
applied to next
- k
next prev parent reply other threads:[~2009-08-07 2:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 20:04 [PATCH 1/3] arch/powerpc: Add kmalloc NULL tests Julia Lawall
2009-08-07 2:26 ` Kumar Gala [this message]
2009-08-07 6:34 ` Daniel K.
2009-08-07 6:51 ` Julia Lawall
2009-08-07 7:00 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FD045DD8-3932-4BA0-9AB9-C2405F601C45@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox