From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 1A236DDF60 for ; Wed, 23 Jan 2008 09:02:42 +1100 (EST) Message-Id: From: Kumar Gala To: Timur Tabi In-Reply-To: <4796605B.2000807@freescale.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Mime-Version: 1.0 (Apple Message framework v915) Subject: Re: [PATCH] [POWERPC] Add docs for Freescale DMA & DMA channel device tree nodes Date: Tue, 22 Jan 2008 16:02:22 -0600 References: <4796605B.2000807@freescale.com> Cc: Scott Wood , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Jan 22, 2008, at 3:30 PM, Timur Tabi wrote: > Kumar Gala wrote: >> Signed-off-by: Zhang Wei >> Signed-off-by: Ebony Zhu >> Signed-off-by: Kumar Gala >> --- >> Guys please review and make sure I got all your previous comments >> fixed >> up. I've added cell-index. and the examples should represent real >> HW. >> Documentation/powerpc/booting-without-of.txt | 128 ++++++++++++++++ >> ++++++++++ >> 1 files changed, 128 insertions(+), 0 deletions(-) >> diff --git a/Documentation/powerpc/booting-without-of.txt b/ >> Documentation/powerpc/booting-without-of.txt >> index da98154..3584c33 100644 >> --- a/Documentation/powerpc/booting-without-of.txt >> +++ b/Documentation/powerpc/booting-without-of.txt >> @@ -2615,6 +2615,134 @@ platforms are moved over to use the >> flattened-device-tree model. >> - clock-frequency : The frequency of the input clock, which >> typically >> comes from an on-board dedicated >> oscillator. >> + * Freescale 83xx DMA Controller >> + >> + Freescale PowerPC 83xx have on chip general purpose DMA >> controllers. >> + >> + Required properties: >> + >> + - compatible : compatible list, contains 2 entries, >> first is >> + "fsl,CHIP-dma", where CHIP is the processor >> + (mpc8349, mpc8360, etc.) and the second is >> + "fsl,elo-dma" >> + - reg : > status reg> >> + - ranges : Should be defined as specified in 1) to describe >> the >> + DMA controller channels. > > What does "Should be defined as specified in 1)" mean? Its referring to section 1 of the doc on ranges. Other nodes use this description for ranges. (soc, muram) >> + - cell-index : controller index. 0 for controller @ >> 0x8100 > > This should be more generic. I believe for each of our SoCs, we > designation one DMA controller to be "DMA Controller 1", and that > one should have a cell-index of "0". Ok, on 83xx that controller is always at offset 0x8100. - k