From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: In-Reply-To: <20070511170512.GH4452@austin.ibm.com> References: <20070510200237.GA19756@mag.az.mvista.com> <20070510215730.GA25075@lixom.net> <17987.47155.935764.878634@cargo.ozlabs.ibm.com> <20070511170512.GH4452@austin.ibm.com> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: From: Kumar Gala Subject: Re: arch/powerpc/sysdev: dumping ground or only for shared drivers? Date: Tue, 15 May 2007 16:06:40 -0500 To: Linas Vepstas Cc: Olof Johansson , linuxppc-dev , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On May 11, 2007, at 12:05 PM, Linas Vepstas wrote: > On Fri, May 11, 2007 at 10:26:27AM +1000, Paul Mackerras wrote: >> Olof Johansson writes: >> >>> This adds yet another set of chipset drivers under sysdev, that are >>> only used by one platform (several board ports under that platform, >>> but only one platforms/* directory). >>> >>> In my opinion, they really should go under the platform directory >>> instead, >>> and not clutter the shared directory. >> >> I disagree, actually. Having these things in a shared directory >> makes >> it more likely that people will look at the code. That means that >> it's more likely that bugs will be found, and more likely that parts >> of the code can get reused when people are doing the port to a new >> chip or board. >> >> If there were hundreds of files in arch/powerpc/sysdev then I >> would be >> more likely to agree with you, but there aren't. > > I like Paul's take, it matches my gut instincts. If this is how we are going we should move some code from arch/ powerpc/platforms into sysdev (for example the 5200 platform has its pic code and some other bits that would be candidate to move into sysdev). - k