LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: nhuquynh@tutamail.com
To: Maddy <maddy@linux.ibm.com>
Cc: Npiggin <npiggin@gmail.com>, Mpe <mpe@ellerman.id.au>,
	Chleroy <chleroy@kernel.org>,
	Linuxppc Dev <linuxppc-dev@lists.ozlabs.org>,
	Kvm <kvm@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] KVM: PPC: Fix callback check in kvmppc_gsm_refresh_info
Date: Tue, 1 Sep 2026 15:26:56 +0200 (CEST)	[thread overview]
Message-ID: <P0S7RHx--F-9@tutamail.com> (raw)

From 80fd05e6d156d5a90d4908f2498bf6cc7acbdefd Mon Sep 17 00:00:00 2001
From: Bui Nguyen Nhu Quynh <nhuquynh@tutamail.com>
Date: Tue, 1 Sep 2026 19:39:49 +0700
Subject: [PATCH] KVM: PPC: Fix callback check in kvmppc_gsm_refresh_info

The kvmppc_gsm_refresh_info() function incorrectly checks for the
presence of the fill_info callback instead of refresh_info.

This can lead to:
- NULL pointer dereference if refresh_info is NULL but fill_info is present
- EINVAL return if refresh_info is present but fill_info is NULL

Fix this by checking the correct callback.

Fixes: 6ccbbc33f06ad ("KVM: PPC: Add helper library for Guest State Buffers")
Signed-off-by: Bui Nguyen Nhu Quynh <nhuquynh@tutamail.com>
---
arch/powerpc/kvm/guest-state-buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/guest-state-buffer.c b/arch/powerpc/kvm/guest-state-buffer.c
index 42843eca6727..aeb586ba4523 100644
--- a/arch/powerpc/kvm/guest-state-buffer.c
+++ b/arch/powerpc/kvm/guest-state-buffer.c
@@ -598,7 +598,7 @@ EXPORT_SYMBOL_GPL(kvmppc_gsm_fill_info);
int kvmppc_gsm_refresh_info(struct kvmppc_gs_msg *gsm,
    struct kvmppc_gs_buff *gsb)
{
-	if (!gsm->ops->fill_info)
+	if (!gsm->ops->refresh_info)
return -EINVAL;
 
return gsm->ops->refresh_info(gsm, gsb);
-- 
2.54.0


             reply	other threads:[~2026-09-01 13:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 13:26 nhuquynh [this message]
2026-09-07  8:33 ` [PATCH] KVM: PPC: Fix callback check in kvmppc_gsm_refresh_info Gautam Menghani
2026-09-07  9:27 ` Amit Machhiwal
2026-09-16 14:07   ` [PATCH v2] " Bui Nguyen Nhu Quynh
2026-09-16 16:44     ` Amit Machhiwal
2026-09-18 14:31   ` [PATCH v3] " Bui Nguyen Nhu Quynh
2026-09-18 17:54     ` Amit Machhiwal
2026-09-21 11:23     ` Gautam Menghani
2026-09-29 11:30     ` Madhavan Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=P0S7RHx--F-9@tutamail.com \
    --to=nhuquynh@tutamail.com \
    --cc=chleroy@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox