[PATCH] powerpc: Fix Kernel FP unavail exception for BookE

[PATCH] powerpc: Fix Kernel FP unavail exception for BookE

[Becky Bruce]

powerpc: Correct BookE FP unavailable exception

Updated FP unavailable exception to refer to the correct
function in traps.c. head_booke.h was using the old name, KernelFP,
instead of kernel_fp_unavailable_exception.

Signed-off-by: Becky Bruce <becky.bruce@freescale.com>

---
commit 6e481b074a1cbe44dd5ccc29fe74857986a41e14
tree 5e3d59136176a927dae2f42ce83b393b17fc86e6
parent 2a68349345a9bf292d06a8baaa8182b946c7056c
author Becky Bruce <becky.bruce@freescale.com> Tue, 31 Jan 2006 17:41:00 -0600
committer Becky Bruce <becky.bruce@freescale.com> Tue, 31 Jan 2006 17:41:00 -0600

 arch/powerpc/kernel/head_booke.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/head_booke.h b/arch/powerpc/kernel/head_booke.h
index 5827c27..8536e76 100644
--- a/arch/powerpc/kernel/head_booke.h
+++ b/arch/powerpc/kernel/head_booke.h
@@ -358,6 +358,6 @@ label:
 	NORMAL_EXCEPTION_PROLOG;					      \
 	bne	load_up_fpu;		/* if from user, just load it up */   \
 	addi	r3,r1,STACK_FRAME_OVERHEAD;				      \
-	EXC_XFER_EE_LITE(0x800, KernelFP)
+	EXC_XFER_EE_LITE(0x800, kernel_fp_unavailable_exception)
 
 #endif /* __HEAD_BOOKE_H__ */

Re: [PATCH] powerpc: Fix Kernel FP unavail exception for BookE

[Kumar Gala]

Acked-by: Kumar Gala <galak@kernel.crashing.org>

On Tue, 31 Jan 2006, Becky Bruce wrote:

> powerpc: Correct BookE FP unavailable exception
> 
> Updated FP unavailable exception to refer to the correct
> function in traps.c. head_booke.h was using the old name, KernelFP,
> instead of kernel_fp_unavailable_exception.
> 
> Signed-off-by: Becky Bruce <becky.bruce@freescale.com>
> 
> ---
> commit 6e481b074a1cbe44dd5ccc29fe74857986a41e14
> tree 5e3d59136176a927dae2f42ce83b393b17fc86e6
> parent 2a68349345a9bf292d06a8baaa8182b946c7056c
> author Becky Bruce <becky.bruce@freescale.com> Tue, 31 Jan 2006 17:41:00 -0600
> committer Becky Bruce <becky.bruce@freescale.com> Tue, 31 Jan 2006 17:41:00 -0600
> 
>  arch/powerpc/kernel/head_booke.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/head_booke.h b/arch/powerpc/kernel/head_booke.h
> index 5827c27..8536e76 100644
> --- a/arch/powerpc/kernel/head_booke.h
> +++ b/arch/powerpc/kernel/head_booke.h
> @@ -358,6 +358,6 @@ label:
>  	NORMAL_EXCEPTION_PROLOG;					      \
>  	bne	load_up_fpu;		/* if from user, just load it up */   \
>  	addi	r3,r1,STACK_FRAME_OVERHEAD;				      \
> -	EXC_XFER_EE_LITE(0x800, KernelFP)
> +	EXC_XFER_EE_LITE(0x800, kernel_fp_unavailable_exception)
>  
>  #endif /* __HEAD_BOOKE_H__ */
> 

Re: [PATCH] powerpc: Fix Kernel FP unavail exception for BookE

[Paul Mackerras]

Becky Bruce writes:

> powerpc: Correct BookE FP unavailable exception

...

> diff --git a/arch/powerpc/kernel/head_booke.h b/arch/powerpc/kernel/head_booke.h

Ummm... which tree has head_booke.h?

Paul.

Re: [PATCH] powerpc: Fix Kernel FP unavail exception for BookE

[Kumar Gala]

On Feb 7, 2006, at 4:30 AM, Paul Mackerras wrote:

> Becky Bruce writes:
>
>> powerpc: Correct BookE FP unavailable exception
>
> ...
>
>> diff --git a/arch/powerpc/kernel/head_booke.h b/arch/powerpc/ 
>> kernel/head_booke.h
>
> Ummm... which tree has head_booke.h?

powerpc.git should have it.  If not this is an issue that should be  
fixed.

Becky, is this change also needed for arch/ppc?  If so can you fixup  
arch/ppc/kernel/head_booke.h and provide patch that duplicates  
head_booke.h in arch/powerpc/kernel if its not there.

- k

Re: [PATCH] powerpc: Fix Kernel FP unavail exception for BookE

[Becky Bruce]

On Feb 7, 2006, at 8:28 AM, Kumar Gala wrote:

>
> On Feb 7, 2006, at 4:30 AM, Paul Mackerras wrote:
>
>> Becky Bruce writes:
>>
>>> powerpc: Correct BookE FP unavailable exception
>>
>> ...
>>
>>> diff --git a/arch/powerpc/kernel/head_booke.h b/arch/powerpc/ 
>>> kernel/head_booke.h
>>
>> Ummm... which tree has head_booke.h?
>
> powerpc.git should have it.  If not this is an issue that should be  
> fixed.


>
> Becky, is this change also needed for arch/ppc?  If so can you  
> fixup arch/ppc/kernel/head_booke.h and provide patch that  
> duplicates head_booke.h in arch/powerpc/kernel if its not there.

No change needed there - it was correct in arch/ppc, just not in arch/ 
powerpc.  The 8540 patch was based on a slightly older copy of the  
file that didn't have this change and we didn't catch the problem in  
testing because the FPU isn't enabled for 8540.  I discovered this  
later.

The 8540 flat tree support patch added this file to arch/powerpc/ 
kernel.  As you pointed out in a different mail, this patch has  
disappeared from the tree recently.

-B