From: Ken Moffat <ken@kenmoffat.uklinux.net>
To: linuxppc-dev@lists.linuxppc.org
Subject: syslib/i8259.c
Date: Sun, 18 Jul 2004 01:12:08 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.58.0407172139370.12839@ppg_penguin.kenmoffat.uklinux.net> (raw)
Is it me, or is i8259_irq_offset redundant ? We test if irq_nr is >=
than it (and subtract it if true), and we pass it to request_irq, but as
far as I can see it never gets set, so we subtract 0 from irq_nr if that
is >= 0.
Ken
--
das eine Mal als Tragödie, das andere Mal als Farce
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
reply other threads:[~2004-07-18 0:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0407172139370.12839@ppg_penguin.kenmoffat.uklinux.net \
--to=ken@kenmoffat.uklinux.net \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).