linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* Fix boot on some 12" powerbooks, need testers on others
       [not found]                               ` <87bqzs5cio.fsf@oedipa.disorg>
@ 2005-12-08 10:48                                 ` Benjamin Herrenschmidt
  2005-12-08 11:12                                   ` Michael Hanselmann
  2005-12-08 15:10                                   ` Dustin Lang
  0 siblings, 2 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2005-12-08 10:48 UTC (permalink / raw)
  To: Guy Yasko; +Cc: linuxppc-dev list

This patch against 2.6.15-rc5 might help fixing boot on some recent
powerbooks like some 12" aluminium. However, I need urgently some
testers with other models of powerbooks and mac mini to tell me if it
causes any regression (that is before tomorrow) so it _might_ have a
chance to make it in 2.6.15.

Index: linux-work/arch/powerpc/platforms/powermac/feature.c
===================================================================
--- linux-work.orig/arch/powerpc/platforms/powermac/feature.c	2005-11-19 10:56:07.000000000 +1100
+++ linux-work/arch/powerpc/platforms/powermac/feature.c	2005-12-08 21:45:30.000000000 +1100
@@ -1650,11 +1650,17 @@
 	 */
 
 	if (macio->type == macio_intrepid) {
-		if (enable)
-			UN_OUT(UNI_N_CLOCK_SPREADING, 2);
-		else
-			UN_OUT(UNI_N_CLOCK_SPREADING, 0);
-		mdelay(40);
+		struct device_node *clock =
+			of_find_node_by_path("/uni-n@f8000000/hw-clock");
+		if (clock && get_property(clock, "platform-do-clockspreading",
+					  NULL)) {
+			if (enable)
+				UN_OUT(UNI_N_CLOCK_SPREADING, 2);
+			else
+				UN_OUT(UNI_N_CLOCK_SPREADING, 0);
+			mdelay(40);
+		}
+		of_node_put(clock);
 	}
 
 	while (machine_is_compatible("PowerBook5,2") ||
Index: linux-work/arch/ppc/platforms/pmac_feature.c
===================================================================
--- linux-work.orig/arch/ppc/platforms/pmac_feature.c	2005-11-14 20:32:16.000000000 +1100
+++ linux-work/arch/ppc/platforms/pmac_feature.c	2005-12-08 21:45:48.000000000 +1100
@@ -1606,11 +1606,17 @@
 	 */
 
 	if (macio->type == macio_intrepid) {
-		if (enable)
-			UN_OUT(UNI_N_CLOCK_SPREADING, 2);
-		else
-			UN_OUT(UNI_N_CLOCK_SPREADING, 0);
-		mdelay(40);
+		struct device_node *clock =
+			of_find_node_by_path("/uni-n@f8000000/hw-clock");
+		if (clock && get_property(clock, "platform-do-clockspreading",
+					  NULL)) {
+			if (enable)
+				UN_OUT(UNI_N_CLOCK_SPREADING, 2);
+			else
+				UN_OUT(UNI_N_CLOCK_SPREADING, 0);
+			mdelay(40);
+		}
+		of_node_put(clock);
 	}
 
 	while (machine_is_compatible("PowerBook5,2") ||

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix boot on some 12" powerbooks, need testers on others
  2005-12-08 10:48                                 ` Fix boot on some 12" powerbooks, need testers on others Benjamin Herrenschmidt
@ 2005-12-08 11:12                                   ` Michael Hanselmann
  2005-12-08 15:10                                   ` Dustin Lang
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Hanselmann @ 2005-12-08 11:12 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: Guy Yasko, linuxppc-dev list

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

> However, I need urgently some testers with other models of powerbooks
> and mac mini to tell me if it causes any regression [...]

Works for me on a PowerBook5,8 (15", 1.67 GHz, Oct 2005).

Greets,
Michael

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix boot on some 12" powerbooks, need testers on others
  2005-12-08 10:48                                 ` Fix boot on some 12" powerbooks, need testers on others Benjamin Herrenschmidt
  2005-12-08 11:12                                   ` Michael Hanselmann
@ 2005-12-08 15:10                                   ` Dustin Lang
  1 sibling, 0 replies; 3+ messages in thread
From: Dustin Lang @ 2005-12-08 15:10 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: Guy Yasko, linuxppc-dev list


It boots on my PowerBook6,2 (12" Oct'03).

Cheers,
dstn.

On Thu, 8 Dec 2005, Benjamin Herrenschmidt wrote:
> This patch against 2.6.15-rc5 might help fixing boot on some recent
> powerbooks like some 12" aluminium. However, I need urgently some
> testers with other models of powerbooks and mac mini to tell me if it
> causes any regression (that is before tomorrow) so it _might_ have a
> chance to make it in 2.6.15.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-12-08 15:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20051026215535.GA5713@campbell-lange.net>
     [not found] ` <1133124018.7768.107.camel@gaston>
     [not found]   ` <87veydaftb.fsf@oedipa.disorg>
     [not found]     ` <1133130209.7768.136.camel@gaston>
     [not found]       ` <877jatemic.fsf@oedipa.disorg>
     [not found]         ` <1133132287.7768.138.camel@gaston>
     [not found]           ` <87oe45d0j4.fsf@oedipa.disorg>
     [not found]             ` <1133142131.7768.156.camel@gaston>
     [not found]               ` <87ek51cycq.fsf@oedipa.disorg>
     [not found]                 ` <1133145863.7768.165.camel@gaston>
     [not found]                   ` <73eb1cf90511271913k1786facev55038e567c51d19c@mail.gmail.com>
     [not found]                     ` <1133150158.7768.177.camel@gaston>
     [not found]                       ` <87zmnpbe34.fsf@oedipa.disorg>
     [not found]                         ` <1133151191.7768.183.camel@gaston>
     [not found]                           ` <87hd9wak4a.fsf@oedipa.disorg>
     [not found]                             ` <1133210294.7768.190.camel@gaston>
     [not found]                               ` <87bqzs5cio.fsf@oedipa.disorg>
2005-12-08 10:48                                 ` Fix boot on some 12" powerbooks, need testers on others Benjamin Herrenschmidt
2005-12-08 11:12                                   ` Michael Hanselmann
2005-12-08 15:10                                   ` Dustin Lang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).