From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by ozlabs.org (Postfix) with SMTP id 99530DDE0E for ; Fri, 23 Feb 2007 09:59:04 +1100 (EST) Date: Thu, 22 Feb 2007 23:58:55 +0100 (CET) From: Guennadi Liakhovetski To: Johannes Berg , David Brownell Subject: Re: several messages In-Reply-To: <200702211950.22422.david-b@pacbell.net> Message-ID: References: <200702211929.17203.david-b@pacbell.net> <200702211950.22422.david-b@pacbell.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Alessandro Zummo , rtc-linux@googlegroups.com, john stultz , linux-pm@lists.osdl.org, Linux Kernel list , Torrance , linuxppc-dev@ozlabs.org, Andrew Morton List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , of the following 2 patches: On Mon, 5 Feb 2007, Johannes Berg wrote: > This patch removes the time suspend/restore code that was done through > a PMU notifier in arch/platforms/powermac/time.c. > > Instead, we introduce arch/powerpc/sysdev/timer.c which creates a sys > device and handles time of day suspend/resume through that. > > Signed-off-by: Johannes Berg > Cc: Andrew Morton > Cc: Benjamin Herrenschmidt [patch trimmed] On Wed, 21 Feb 2007, David Brownell wrote: > RTC class suspend/resume support, re-initializing the system clock on resume > >from the clock used to initialize it at boot time. > > - Inlining the same code used by ARM, which saves and restores the > delta between a selected RTC and the current system wall-clock time. > > - Removes calls to that ARM code from AT91, OMAP, and S3C RTCs. > > This goes on top of the patch series removing "struct class_device" usage > >from the RTC framework. That makes class suspend()/resume() work. > > Signed-off-by: David Brownell > > --- > drivers/rtc/Kconfig | 24 +++++++++---- > drivers/rtc/class.c | 74 +++++++++++++++++++++++++++++++++++++++++++ > drivers/rtc/rtc-at91rm9200.c | 30 ----------------- > drivers/rtc/rtc-omap.c | 17 --------- > drivers/rtc/rtc-s3c.c | 22 ------------ > 5 files changed, 91 insertions(+), 76 deletions(-) [patch trimmed] I think, we only want 1, right? And the latter seems to be more generic / platform independent? And as a side-effect, powermac would have to migrate to generic rtc:-) Thanks Guennadi --- Guennadi Liakhovetski