From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org,
Johannes Berg <johannes@sipsolutions.net>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] power-management elements for 603e/fsl (version 2)
Date: Sun, 1 Jul 2007 23:19:09 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.60.0707012253420.4652@poirot.grange> (raw)
In-Reply-To: <Pine.LNX.4.60.0705212225470.7562@poirot.grange>
On Mon, 21 May 2007, Guennadi Liakhovetski wrote:
> On Mon, 21 May 2007, Scott Wood wrote:
>
> > IRQs really shouldn't be enabled here without something like the "Handle
> > HID0_SLEEP in the TLF_NAPPING hack" patch I posted recently.
>
> Ok, I'd be happy to rely on those your patches... as long as they make it
> into the kernel. Paulus, what's the plan? I'll try to apply them locally
> for now and adjust my code accordingly. A recent powerpc.git should be
> fine, I guess - the arch_suspend_{disable,enable}_irqs hooks are already
> there, or are there any further dependencies?
Took some time, but now I did rebase my linkstation standby code on your
patches, and also used your mpc83xx_enter_sleep / ret_from_sleep functions
(former with a single modification - removed the first mtmsr to set EE and
POW in MSR with one insn) - all worked. So, we could put them into
something like arch/powerpc/sysdev/fsl_pm.S and name accordingly. That
could be an incremental patch after the present versions make it into some
tree.
Of course, I needed other your patches to, e.g., bypass calling the ISR on
resume too.
Thanks
Guennadi
---
Guennadi Liakhovetski
prev parent reply other threads:[~2007-07-01 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-19 19:22 [PATCH] power-management elements for 603e/fsl (version 2) Guennadi Liakhovetski
2007-05-21 15:54 ` Johannes Berg
2007-05-21 15:57 ` Scott Wood
2007-05-21 20:50 ` Guennadi Liakhovetski
2007-07-01 21:19 ` Guennadi Liakhovetski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.60.0707012253420.4652@poirot.grange \
--to=g.liakhovetski@gmx.de \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox